[scanner] fix: pin infra workflow refs and add fork guards#5957
[scanner] fix: pin infra workflow refs and add fork guards#5957clubanderson wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
❌ Deploy Preview for kubestellar-docs failed. Why did it fail? →
|
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@clubanderson: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Pull request overview
This PR targets the supply-chain risk described in #5940 by replacing mutable @main reusable-workflow references to kubestellar/infra with immutable commit SHAs, and by adding fork guards to pull_request_target workflows.
Changes:
- Pin the
kubestellar/infrareusable workflow reference inai-fix.ymlto a specific commit SHA. - Pin the
kubestellar/infrareusable workflow reference inlabel-helper.ymlto a specific commit SHA.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ai-fix.yml | Pins the referenced kubestellar/infra reusable workflow to a commit SHA. |
| .github/workflows/label-helper.yml | Pins the referenced kubestellar/infra reusable workflow to a commit SHA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| ai-fix: | ||
| uses: kubestellar/infra/.github/workflows/reusable-ai-fix.yml@main | ||
| uses: kubestellar/infra/.github/workflows/reusable-ai-fix.yml@af322d48cc67ade7345cabc6a0ed55c6c7040ee4 # main |
|
Scanner note: This PR has a merge conflict because the fork guard was added to To resolve: rebase onto main, which will auto-resolve the conflict since both changes (fork guard + pinned SHA) are compatible. git fetch origin main
git rebase origin/main
git push --force-with-leaseCannot fix via API due to |
Fixes #5940
Pins kubestellar/infra reusable workflow references to immutable commit SHAs and adds fork guards to pull_request_target workflows.