Align set with k/k apimachinery by skitt · Pull Request #294 · kubernetes/utils

skitt · 2023-11-23T14:18:00Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This aligns the features of generic Set with the version in apimachinery. The main change is that sets can be instantiated with any comparable type, not only ordered types; as a result, SortedList() can no longer be implemented as a method, and is replaced by the List() function to match apimachinery.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

sets.Set accepts any comparable type; the sets.SortedList method is replaced with a sets.List function, to match the apimachinery implementation, and to allow unordered sets to be converted to ordered slices.

logicalhan

/lgtm
/approve

skitt · 2023-11-23T16:09:59Z

Thanks @logicalhan! There’s a failure in apidiff but I don’t think it’s significant — the changes are expected (or bugs in apidiff).

logicalhan · 2023-11-23T16:13:38Z

/hold

logicalhan · 2023-11-23T16:13:57Z

Thanks @logicalhan! There’s a failure in apidiff but I don’t think it’s significant — the changes are expected (or bugs in apidiff).

It is significant because we don't know who's using this.

skitt · 2023-11-23T16:15:47Z

It is significant because we don't know who's using this.

The changes are listed as follows:

- KeySet: changed from func(map[E]A) Set[E] to func(map[E]A) Set[E]
- New: changed from func(...E) Set[E] to func(...E) Set[E]
- Set: changed from Set[E ordered] to Set[E comparable]

The first two aren’t changes. The last one is fine because comparable is a superset of ordered, so any existing Set will still build.

k8s-triage-robot · 2024-02-21T16:54:31Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

skitt · 2024-02-21T16:57:35Z

/remove-lifecycle stale

k8s-triage-robot · 2024-05-21T17:40:25Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

skitt · 2024-05-22T07:44:48Z

/remove-lifecycle stale

k8s-triage-robot · 2024-08-20T08:39:21Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

skitt · 2024-08-20T11:44:31Z

/remove-lifecycle stale

k8s-triage-robot · 2024-11-18T12:30:54Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

skitt · 2025-06-17T15:02:54Z

/remove-lifecycle rotten

k8s-triage-robot · 2025-09-15T15:41:38Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

skitt · 2025-09-15T16:10:00Z

/remove-lifecycle stale

k8s-triage-robot · 2025-12-14T16:27:09Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

skitt · 2025-12-15T09:02:17Z

/remove-lifecycle stale

k8s-ci-robot · 2025-12-18T17:05:34Z

New changes are detected. LGTM label has been removed.

This aligns the features of generic Set with the version in apimachinery. The main change is that sets can be instantiated with any comparable type, not only ordered types; as a result, SortedList() can no longer be implemented as a method, and is replaced by the List() function to match apimachinery. Signed-off-by: Stephen Kitt <skitt@redhat.com>

k8s-ci-robot · 2026-03-12T15:30:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logicalhan, skitt
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

set/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dims · 2026-03-12T15:37:53Z

/assign @pohly @liggitt

skitt · 2026-03-12T15:51:54Z

The apidiff failure is

FAIL: k8s.io/utils/set contains incompatible changes:
- KeySet: changed from func(map[E]A) Set[E] to func(map[E]A) Set[E]
- New: changed from func(...E) Set[E] to func(...E) Set[E]
- Set: changed from Set[E ordered] to Set[E comparable]

The change it’s complaining about is the last one, which percolates up through the stack. But in practice I don’t think it’s a breaking API change: current code using k/u Set with an ordered type will compile fine with the new one, since an ordered type is also comparable.

Go 1.21+ provides cmp.Ordered which serves the same purpose as set's private ordered type. Signed-off-by: Stephen Kitt <skitt@redhat.com>

k8s-triage-robot · 2026-06-11T13:32:17Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

skitt · 2026-06-11T14:20:58Z

/remove-lifecycle stale

pohly · 2026-06-30T14:42:27Z

@@ -17,19 +17,21 @@ limitations under the License.
 package set


The main obstacle for transitioning from k8s.io/apimachinery/pkg/util/sets to k8s.io/utils/set: the former uses plural and thus code has sets.New, the latter singular and thus would have to change imports to sets "k8s.io/utils/set" (ugly!) or change the code (also ugly!).

"set" is arguably the better name (there's only one set type here). Also, these files have all the commit history. Maybe we can create a mirror package k8s.io/utils/sets with a typedef Set = set.Set and function wrappers for the few functions here (New, List, KeySet)?

pohly · 2026-06-30T14:43:15Z


 // KeySet creates a Set[E] from a keys of a map[E](? extends interface{}).
-func KeySet[E ordered, A any](theMap map[E]A) Set[E] {
+// If the value passed in is not actually a map, this will panic.


Okay, I bite: how can theMap not be a map?

k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 23, 2023

k8s-ci-robot requested review from logicalhan and thockin November 23, 2023 14:18

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 23, 2023

logicalhan approved these changes Nov 23, 2023

View reviewed changes

k8s-ci-robot assigned logicalhan Nov 23, 2023

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2023

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2023

wallrj mentioned this pull request Jan 2, 2024

Replace calls to deprecated sets.String functions cert-manager/cert-manager#6586

Merged

2 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 21, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 21, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2024

skitt mentioned this pull request Oct 7, 2024

[Umbrella] Make client-go lighter and easier to consume kubernetes/kubernetes#127888

Open

4 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2024

k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 17, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 17, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2025

skitt force-pushed the align-apimachinery-set branch from 93a9af8 to 9ec58aa Compare December 18, 2025 17:05

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2025

skitt force-pushed the align-apimachinery-set branch from 9ec58aa to 9156a7c Compare March 12, 2026 15:30

k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2026

k8s-ci-robot assigned liggitt and pohly Mar 12, 2026

Drop ordered in favour of cmp.Ordered

9ae1dad

Go 1.21+ provides cmp.Ordered which serves the same purpose as set's private ordered type. Signed-off-by: Stephen Kitt <skitt@redhat.com>

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2026

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2026

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2026

pohly reviewed Jun 30, 2026

View reviewed changes

		@@ -17,19 +17,21 @@ limitations under the License.
		package set

Uh oh!

Conversation

skitt commented Nov 23, 2023

Uh oh!

logicalhan left a comment

Choose a reason for hiding this comment

Uh oh!

skitt commented Nov 23, 2023

Uh oh!

logicalhan commented Nov 23, 2023

Uh oh!

logicalhan commented Nov 23, 2023

Uh oh!

skitt commented Nov 23, 2023

Uh oh!

k8s-triage-robot commented Feb 21, 2024

Uh oh!

skitt commented Feb 21, 2024

Uh oh!

k8s-triage-robot commented May 21, 2024

Uh oh!

skitt commented May 22, 2024

Uh oh!

k8s-triage-robot commented Aug 20, 2024

Uh oh!

skitt commented Aug 20, 2024

Uh oh!

k8s-triage-robot commented Nov 18, 2024

Uh oh!

skitt commented Jun 17, 2025

Uh oh!

k8s-triage-robot commented Sep 15, 2025

Uh oh!

skitt commented Sep 15, 2025

Uh oh!

k8s-triage-robot commented Dec 14, 2025

Uh oh!

skitt commented Dec 15, 2025

Uh oh!

k8s-ci-robot commented Dec 18, 2025

Uh oh!

k8s-ci-robot commented Mar 12, 2026

Uh oh!

dims commented Mar 12, 2026

Uh oh!

skitt commented Mar 12, 2026

Uh oh!

k8s-triage-robot commented Jun 11, 2026

Uh oh!

skitt commented Jun 11, 2026

Uh oh!

pohly Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pohly Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pohly Jun 30, 2026 •

edited

Loading