remove legacy prow cluster configuration#36655
remove legacy prow cluster configuration#36655BenTheElder wants to merge 2 commits intokubernetes:masterfrom
Conversation
|
@BenTheElder: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-k8s-infra-leads. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -1,47 +0,0 @@ | |||
| --- | |||
| gitHubLogin: "k8s-infra-ci-robot" | |||
There was a problem hiding this comment.
Actually, we might still need this one?
56857f5 to
1200389
Compare
this was used by the google operated prow cluster, current config is in github.com/kubernetes/k8s.io
1200389 to
e1669cc
Compare
michelle192837
left a comment
There was a problem hiding this comment.
I think this is fine, but there are references to it in Prow documentation unfortunately (https://github.com/search?q=repo%3Akubernetes-sigs%2Fprow+test-infra%2Fblob%2Fmaster%2Fconfig%2Fprow%2Fcluster&type=code).
I don't think that needs to block this but we should follow up with a doc update. (Might be a good help-wanted or first issue? 🤔 )
/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Oh, yeah. I mean these are definitely out of date, if we want to point at Kubernetes's we can point at the files in github.com/kubernetes/k8s.io I wonder if we should be pointing at the starter copies in the prow repo though. cc @petr-muller -- FYI |
|
+1 for removing the terraform code. For the rest, not tombstone files? are we not breaking downstream ? |
|
I mean we should update the docs, but these are defunct, they haven't been updated in ages. starter configs were already migrated IIRC |
this was used by the google operated prow cluster, current config is in github.com/kubernetes/k8s.io
/hold
/cc @kubernetes/sig-k8s-infra-leads