Call DescribeInstanceTypes at runtime to get multi-card info#2916
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Apr 17, 2026
Merged
Call DescribeInstanceTypes at runtime to get multi-card info#2916k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
Contributor
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Code Coverage Diff
|
Contributor
Author
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
torredil
reviewed
Apr 10, 2026
Member
torredil
left a comment
torredil
left a comment
There was a problem hiding this comment.
Largely lgtm, one suggestion.
Signed-off-by: Connor Catlett <conncatl@amazon.com>
ConnorJC3
force-pushed
the
dit-for-multicard
branch
from
f6dc8d5 to
6c8d330
Compare
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What is this PR about? / Why do we need it?
Call DIT at runtime to get the latest EBS multi-card info for an instance rather than using a built in hardcoded table.
How was this change tested?
Unit tests + E2E tests (modified to mock new API calls)
Does this PR introduce a user-facing change?