Skip to content

Update images in Tinkerbell template#2019

Closed
dakraus wants to merge 1 commit into
kubermatic:mainfrom
dakraus:feat/tinkerbell-template-images
Closed

Update images in Tinkerbell template#2019
dakraus wants to merge 1 commit into
kubermatic:mainfrom
dakraus:feat/tinkerbell-template-images

Conversation

@dakraus
Copy link
Copy Markdown
Contributor

@dakraus dakraus commented May 8, 2026

What this PR does / why we need it:

Updates the images used in the Tinkerbell template and pins them down to the latest available tags.

Which issue(s) this PR fixes:

Fixes #2018

What type of PR is this?

/kind chore

Special notes for your reviewer:

  • According to the README, all images are built, tagged with the Git revision, and pushed to quay.io for each commit on main. That's why I used the same tag for all actions.

Does this PR introduce a user-facing change? Then add your Release Note here:

Tinkerbell: Update the image of all actions used in the template

Documentation:

NONE

@dakraus
Update images in Tinkerbell template
8a13b54 
Signed-off-by: Daniel Kraus <daniel.kraus@kubermatic.com>
@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels May 8, 2026
@kubermatic-bot
Copy link
Copy Markdown
Contributor

kubermatic-bot commented May 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ahmedwaleedmalik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2026
moadqassem
moadqassem requested changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please mirror all the images that used in the tinkerbell templates so that we will be independent of what upstream remove in the future? All these image should be mirrored under this org https://quay.io/organization/kubermatic-mirros/

Comment thread pkg/cloudprovider/provider/baremetal/plugins/tinkerbell/client/template.go
return Action{
Name: "stream-ubuntu-image",
Image: "quay.io/tinkerbell-actions/image2disk:v1.0.0",
Image: "quay.io/tinkerbell/actions/image2disk:2a7c298fe0292737371ca11913e3c0c3bf794981",
Copy link
Copy Markdown
Member

@moadqassem moadqassem May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please mirror these images into our own quay org? This is the name of the org https://quay.io/organization/kubermatic-mirros/

@dakraus
Copy link
Copy Markdown
Contributor Author

dakraus commented May 21, 2026

/close superseded by #2022 which updates the images and includes the mirroring

@dakraus dakraus closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moadqassem moadqassem moadqassem requested changes

Assignees

@moadqassem moadqassem

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update images in Tinkerbell template

3 participants

@dakraus @kubermatic-bot @moadqassem