Skip to content

Fix IDE0370 build errors from .NET 10 SDK analyzer #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-edmondson merged 1 commit into from
Jun 12, 2026
Merged

Fix IDE0370 build errors from .NET 10 SDK analyzer #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Semantics.Quantities/Core/SemanticQuantity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public static TResult Multiply<TResult>(SemanticQuantity<TStorage> self, Semanti
{
Ensure.NotNull(self);
Ensure.NotNull(other);
return Create<TResult>(self.Quantity * other.Quantity)!;
return Create<TResult>(self.Quantity * other.Quantity);
}

/// <summary>
Expand All @@ -81,7 +81,7 @@ public static TResult Multiply<TResult>(SemanticQuantity<TStorage> self, TStorag
where TResult : SemanticQuantity<TStorage>, new()
{
Ensure.NotNull(self);
return Create<TResult>(self.Quantity * other)!;
return Create<TResult>(self.Quantity * other);
}

/// <summary>
Expand All @@ -96,7 +96,7 @@ public static TResult Divide<TResult>(SemanticQuantity<TStorage> self, SemanticQ
{
Ensure.NotNull(self);
Ensure.NotNull(other);
return Create<TResult>(self.Quantity / other.Quantity)!;
return Create<TResult>(self.Quantity / other.Quantity);
}

/// <summary>
Expand All @@ -110,7 +110,7 @@ public static TResult Divide<TResult>(SemanticQuantity<TStorage> self, TStorage
where TResult : SemanticQuantity<TStorage>, new()
{
Ensure.NotNull(self);
return Create<TResult>(self.Quantity / other)!;
return Create<TResult>(self.Quantity / other);
}

/// <summary>
Expand Down Expand Up @@ -142,7 +142,7 @@ public static TResult Add<TResult>(SemanticQuantity<TStorage> self, SemanticQuan
{
Ensure.NotNull(self);
Ensure.NotNull(other);
return Create<TResult>(self.Quantity + other.Quantity)!;
return Create<TResult>(self.Quantity + other.Quantity);
}

/// <summary>
Expand All @@ -157,7 +157,7 @@ public static TResult Subtract<TResult>(SemanticQuantity<TStorage> self, Semanti
{
Ensure.NotNull(self);
Ensure.NotNull(other);
return Create<TResult>(self.Quantity - other.Quantity)!;
return Create<TResult>(self.Quantity - other.Quantity);
}

/// <summary>
Expand All @@ -170,7 +170,7 @@ public static TResult Negate<TResult>(SemanticQuantity<TStorage> self)
where TResult : SemanticQuantity<TStorage>, new()
{
Ensure.NotNull(self);
return Create<TResult>(-self.Quantity)!;
return Create<TResult>(-self.Quantity);
}

/// <inheritdoc/>
Expand Down
6 changes: 4 additions & 2 deletions Semantics.Strings/SemanticString.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace ktsu.Semantics.Strings;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.Reflection;
using System.Text;
using System.Text.Json.Serialization;

Expand Down Expand Up @@ -557,8 +558,9 @@ private static TDest FromStringInternal<TDest>(string? value)
Ensure.NotNull(value);

Type typeOfTDest = typeof(TDest);
TDest newInstance = (TDest)Activator.CreateInstance(type: typeOfTDest)!;
typeOfTDest.GetProperty(name: nameof(WeakString))!.SetValue(obj: newInstance, value: newInstance.MakeCanonical(value));
TDest newInstance = (TDest)Ensure.NotNull(Activator.CreateInstance(type: typeOfTDest));
PropertyInfo weakStringProperty = Ensure.NotNull(typeOfTDest.GetProperty(name: nameof(WeakString)));
weakStringProperty.SetValue(obj: newInstance, value: newInstance.MakeCanonical(value));
return newInstance;
}

Expand Down
Loading