Example app entries#205
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds several AMS fraction macros (such as \tfrac, \dfrac, \cfrac, \dbinom, \tbinom) and AMS multi-integrals (such as \iint, \iiint, \iiiint, \oiint, \varointclockwise, \ointctrclockwise, \fint) to both the MathDemoFormulas and MathTestFormulas arrays in MathExamples.h. There are no review comments to address, and I have no additional feedback to provide.
Code Review — PR 205: Example app entriesOverall this is a clean, low-risk PR that correctly adds the new LaTeX gallery strings to both Issues1. The PR description and commit message both claim "8 multi-integrals", but only 7 are exercised in the gallery. Suggested fix — replace the third gallery line with one that covers all three missing symbols at once: @"\\oiiint \\, \\varointclockwise \\, \\ointctrclockwise \\, \\fint",Or keep the existing third line and add a fourth: @"\\oiiint_V h \\, dV",Without this, a visual regression in 2. Plan-specified inline comments were dropped (minor) The plan (docs/plans/…, item 19 step 2) specified per-entry comments: // dfrac vs tfrac vs cfrac size comparison
// Nested continued fraction
// cfrac alignment showcase
// dbinom vs tbinomThe implementation uses only a single section-header comment ( Nits3. Items 0–30 are numbered in comments. The new entries at lines 111–118 have no numbers assigned. That is fine for unnumbered continuation, but the comment on line 21 of the file ( 4. Duplication between All 7 new strings are identical copies in both arrays. That is consistent with how existing entries that appear in both are handled (e.g., entries 6 and 7 are identical), so this is not a new pattern problem — but worth flagging that the two arrays now both carry the same visual-demo strings, which may not be the intent for Confirmed correct
|
c32649f to
68c9a6f
Compare
3961abb to
727192a
Compare
68c9a6f to
fb586ae
Compare
727192a to
b992fd9
Compare
fb586ae to
1bea734
Compare
Follow-up to dropping \fint from supportedLatexSymbols (PR 204): the example arrays in MathExamples.h referenced \fint, which would now render as .notdef. Remove it from the multi-integral example line. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
b992fd9 to
a00242a
Compare
Summary
Adds visual gallery entries for all 13 new commands (5 fraction macros + 8 multi-integrals) to
MathExamples.h. This is PR 4 of 4 — the final PR in the AMSMath fractions + multi-integral stack.Plan:
docs/plans/2026-05-25-amsmath-fractions-and-multi-integrals.mdLLD:
docs/lld/2026-05-25-amsmath-fractions-and-multi-integrals.mdGoal
Add visual gallery entries to
MathDemoFormulas()andMathTestFormulas()inMathExamples.hso reviewers can eyeball the rendering of all new commands across the example apps. No iosMath source changes.Commits
[item 19]Add\dfrac/\tfrac/\cfrac/\dbinom/\tbinomexamples to gallery[item 20]Add\iint/\iiint/\iiiint/\oiint/\oiiint/\fint/contour examplesStack
Example strings added
Fraction macros:
\tfrac{1}{2} + \dfrac{1}{2} = \cfrac{1}{1+\cfrac{1}{1}}x = \cfrac{1}{1+\cfrac{1}{x+\cfrac{1}{x+\cfrac{1}{x}}}}\cfrac[l]{1}{1+x} \quad \cfrac[c]{1}{1+x} \quad \cfrac[r]{1}{1+x}\dbinom{n}{k} \quad \tbinom{n}{k}Multi-integrals:
\iint_S f \, dA = \iiint_V g \, dV = \iiiint_{\mathbb{R}^4} h \, dV\oiint_{\partial V} \vec{F} \cdot d\vec{A} = \iiint_V (\nabla\cdot\vec{F}) \, dV\varointclockwise \, \ointctrclockwise \, \fintTest plan