Add CorpusStorage::find_extra returning the query alternative for each match - #342
Open
matthias-stemmler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
CorpusStorage::find_extramethod that returns for each match which query alternative produced it. In case multiple alternatives produce the same match, it gets attributed to the first alternative.The new method has the same signature as
CorpusStorage::find, except that it returns aVec<MatchExtra>instead of aVec<String>. TheMatchExtrastruct is marked#[non_exhaustive]so that adding more fields later isn't a breaking change. The namesfind_extraandMatchExtrafollow the convention established forcount_extraandCountExtra.Performance: the alternative index is a plain
usizecarried alongside the numeric match group, so it stays out of the sort key and the uniqueness check, and match IDs are still resolved to strings at the end. I did extract the common parts offindandfind_extra: The added cost forfindis thatusizeper match in the temporary BTree index plus one iterator indirection; it showed no measurable effect on the GUM test corpus.I didn't extend the FFI surface for now.
Closes #341.