Repository navigation
Align standalone engine dependencies and bound protected request rates - #31
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5018c956d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kopachlager
enabled auto-merge (squash)
October 18, 2026 11:10
kopachlager
disabled auto-merge
October 18, 2026 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone engine's pending browser updates install mismatched Playwright packages and images, causing Chromium startup failures. Its runtime image also fails the security scan, and authenticated endpoints lack a local request-rate budget. Align the npm package and pinned image at 1.64.0, refresh Ubuntu security packages, retain proxy-addr 2.0.8, and refresh the pinned CI/release actions.
Add a configurable shared request budget before JSON parsing, authorization, URL validation or browser allocation. The default is 600 requests/minute per process. It covers failed authentication and malformed/oversized bodies, returns 429 with Retry-After and standard rate-limit headers, and exposes those headers to explicitly allowed browser origins. Oversized request JSON returns a stable 413. Health/readiness probes remain available. One constant budget key avoids trusting forwarded IPs or allocating attacker-controlled client buckets. External proxy limits and private ingress remain required.
Validation: all 38 unit/API tests pass on Node 20, 22 and 24; all 10 real-Chromium fixtures pass; runtime vulnerability scan and container readiness smoke test pass; npm audit reports zero vulnerabilities; the final PR CodeQL analysis reports zero findings. Regression coverage includes package/image alignment, all protected routes, parser failures, forwarded-header bypass attempts, probe availability and browser retry headers.
Supersedes #16, #23, #24, #25, #26, #27, #28 and #29. The original Playwright PRs would still mismatch if merged together as written.
Scope is this standalone public repository. No version tag, container publication or managed-service deployment is included. Changelog/API documentation mark the new behavior as unreleased, and published v0.1.3 installation references remain unchanged.
Fixes #30.