[science-enthusiast]

This is based on the investigation by @yasahi-hpc as described here.

Currently, the workflow defined in generate-slides.yaml attempts to build the tip of main branch, instead of the tip of the PR branch. With this PR, the tip of the PR branch will be picked up by default for the build.

[yasahi-hpc]

Thanks
In my opinion, we should build PDFs from PR

[lucbv]

Can we modify this so we only upload the slides that are actually merged to master and not every thing that passes the CI tests?

[science-enthusiast]

Can we modify this so we only upload the slides that are actually merged to master and not every thing that passes the CI tests?

A condition has been added to check for merge into main. (It was figured out with the help of Claude.)

[masterleinad]

Can we modify this so we only upload the slides that are actually merged to master and not every thing that passes the CI tests?

Why are you opposed to uploading the slides as artifacts?

[yasahi-hpc]

I also prefer to uploading the slides as artifacts
When the PR is merged, the final artifact is identical to the one from main.

[lucbv]

I read this too quickly, uploading these artifacts are fine.
The intent of this action is to build and deploy the slide not to provide CI for them.
With only the small code changes visible it made it sound like we might push and deploy all CI artifact which would not be good...
Sorry for my miss read

[science-enthusiast]

I can roll back the second commit but I don't understand properly the discussion. I thought uploading the PDFs that are based on what is merged is better. Isn't it wasteful to upload PDFs at the intermediate stages?

[masterleinad]

I can roll back the second commit but I don't understand properly the discussion. I thought uploading the PDFs that are based on what is merged is better. Isn't it wasteful to upload PDFs at the intermediate stages?

"Uploading" and "deploying" are two different steps. The former makes the PDFs downloadable from the CI page (which makes reviewing easier) and the latter updates the slides on the webpage (which we should only do on main).

[science-enthusiast]

I can roll back the second commit but I don't understand properly the discussion. I thought uploading the PDFs that are based on what is merged is better. Isn't it wasteful to upload PDFs at the intermediate stages?

"Uploading" and "deploying" are two different steps. The former makes the PDFs downloadable from the CI page (which makes reviewing easier) and the latter updates the slides on the webpage (which we should only do on main).

Thanks for your clarification. I did notice a job called "deploy". I could have framed a smarter question.

[science-enthusiast]

All checks have passed.