Skip to content

add update method to Record class#270

Open
evstratbg wants to merge 1 commit into
koalalorenzo:mainfrom
evstratbg:patch-1
Open

add update method to Record class#270
evstratbg wants to merge 1 commit into
koalalorenzo:mainfrom
evstratbg:patch-1

Conversation

@evstratbg

Copy link
Copy Markdown

add update domain record support

add update domain record support
@koalalorenzo

Copy link
Copy Markdown
Owner

Do we have tests?

@koalalorenzo koalalorenzo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing

@evstratbg

evstratbg commented Jan 20, 2020

Copy link
Copy Markdown
Author

Oops, gonna code it this week

@evstratbg

Copy link
Copy Markdown
Author

There is no tests for Record class. Should I implement this?

@koalalorenzo

koalalorenzo commented Feb 19, 2020

Copy link
Copy Markdown
Owner

Yes that would be nice! Check how it has been done in other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants