Skip to content

Filter tasks by whether they are done - #8

Open
klind wants to merge 2 commits into
mainfrom
agentsatwork/f38296dc-filter-tasks-by-whether-they-are-done
Open

klind wants to merge 2 commits into
mainfrom
agentsatwork/f38296dc-filter-tasks-by-whether-they-are-done

Conversation

@klind

@klind klind commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Job f38296dc.

What was asked

Let a client list only the tasks that are done, or only those that are not.

  • GET /tasks?done=true lists only the tasks that are done, and GET /tasks?done=false only those that are not, in the same order and shape as GET /tasks.
  • GET /tasks with no done parameter lists every task, as it does now.
  • Any other value of done answers 400 and lists nothing.
  • Add tests for the three cases.
  • Say in the README's table that GET /tasks takes ?done=true or ?done=false.

Review

1 review round by: reviewer.

The last review left nothing open.


Opened by AgentsAtWork.

klind and others added 2 commits October 24, 2026 19:23
GET /tasks?done=true lists only the tasks that are done and ?done=false
only those that are not, in the same order and shape as GET /tasks.
Without the parameter every task is listed, as before. Any other value,
including an empty or repeated one, answers 400 so a client never gets
a list it did not ask for.

TaskList.all takes an optional done argument for the filter. The README
table and the changelog say so; the changelog line still needs the pull
request's number appended.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The build check failed because CHANGELOG.md had no new line under
Unreleased ending with this pull request's number. The line for
GET /tasks?done= now ends with (#8).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant