Repository navigation
Rename a task - #5
Merged
Merged
Conversation
PATCH /tasks/:id with a body {"title": "..."} renames a task and answers
200 with it. An unknown id answers 404, and a missing, empty, or non-text
title answers 400 and leaves the task as it was.
TaskList.rename does the work. The title rule moves out of add into one
function that both add and rename call, so a rename is checked and trimmed
exactly as a new task is. The id and done stay untouched.
The changelog line has no pull request number yet, because the number is
not known before the pull request is opened.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec
SAMPLE-9.What was asked
Let a client change the title of a task.
PATCH /tasks/:idwith a JSON body{ "title": "<new title>" }changes the task's title and answers 200 with the task.TaskListthat renames a task, and use it from the server.Review
2 review rounds by: reviewer.
Declined by the engineer, for a reason the reviewer accepted:
CHANGELOG.md:8: The new changelog line does not end with the pull request's number, so the CI changelog step will fail on the pull request. (reviewer-1-1). The engineer: The finding is right that the line needs ' (#N)', but it cannot be done at this point: the pull request does not exist yet. Branch agentsatwork/SAMPLE-9 has no remote counterpart (only SAMPLE-4 and SAMPLE-7 are on origin), nothing in .agent/ or the environment carries a number, and I am not allowed to call the code host to look one up. The finding itself says the fix applies 'once the pull request exists'. Guessing the next number is unsafe: other branches (SAMPLE-3 to SAMPLE-8) may open pull requests first, and a wrong number fails the same CI step while leaving a false reference in CHANGELOG.md. No code was changed and nothing was committed; build and all 16 tests pass. To settle this, the pipeline needs to supply the pull request number (or run this fix step after opening the pull request), and then the line '-PATCH /tasks/:idchanges a task's title, body{"title": "..."}.' in CHANGELOG.md gets ' (#N)' appended.The last review left nothing open.
Opened by AgentsAtWork.