fix: retry worklet registration when view tag resolves late - #1613
Open
JoaoPauloCMarra wants to merge 1 commit into
Open
fix: retry worklet registration when view tag resolves late#1613JoaoPauloCMarra wants to merge 1 commit into
JoaoPauloCMarra wants to merge 1 commit into
Conversation
Contributor
📊 Package size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Retry worklet-handler registration for up to two animation frames when a React ref exists but Fabric has not exposed its native view tag yet. Pending registration is cancelled during cleanup, including registration that was already deferred to a microtask.
💡 Motivation and Context
Fixes #1612.
useEventHandlerRegistrationcurrently checksfindNodeHandleonly once whenviewTagRef.currentis populated. During a Fabric mount, the ref can become available before its native tag. If that check returnsnull, the library logs a warning and leaves the handler detached for the lifetime of the mounted provider.Runtime reproduction:
KeyboardProviderand mount a consumer such asuseKeyboardHandler,KeyboardToolbar, orKeyboardAwareScrollViewduring the initial provider mount.view tag can not be resolvedwarning and missing worklet callbacks for that provider.The deterministic regression holds
findNodeHandleatnullfor the initial lookup and two animation-frame lookups. Before this change,registerForEventsis never called. With this change, registration succeeds when the tag appears on the second frame.Platform scope:
📢 Changelog
JS
🤔 How Has This Been Tested?
yarn test src --runInBand— 27 suites, 217 tests passed.cd example && yarn test --runInBand— 11 suites, 23 tests passed.cd FabricExample && yarn test --runInBand— 11 suites, 23 tests passed.yarn typescriptyarn lintyarn prettier '**/*' --ignore-unknown --check📸 Screenshots (if appropriate):
Not applicable. The regression is handler registration timing; its stable signals are the warning and missing callbacks.
📝 Checklist