Repository navigation
Conversation
Add a separately reviewed workbook-only ARM route with semantic compact snapshots, pinned lab/user identity, runtime Provider validation and authoritative deployment polling. Keep extension-direct and runtime qualification contracts unverified. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use subscription-only Azure CLI token acquisition while preserving exact approved tenant and principal checks. Model incompatible token arguments and cover blocked preflight reuse without weakening durable submission gates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Maintainer follow-up: d58b621 fixes Azure CLI ARM token preflight to use Validation: all 17 focused synthetic ARM workbook deployment tests passed; the runner now rejects combined arguments. Regression coverage verifies both subscription-only checks, wrong-tenant rejection before validation/reservation/write, reuse of an unchanged approved plan after a preflight-only failure, and continued no-retry after submission. Offline inspection of both existing approved local plans confirms unchanged plan hashes/provenance/snapshots, blocked preflight evidence with This remains stacked on the existing base; no upstream branch was modified. |
Maintainer scope / stacked dependency
Separate explicitly authorized toolkit-maintainer implementation. This fork PR isolates the new route on
kingwil/toolkit-reviewed-workbook-updates(8d45648), since upstream oferInbar#9 remains OPEN. No oferInbar branch was modified. After PR9 merges, carry a3a077d into a new upstream PR againstSolution-toolkit-master.Supported normal ARM route
Add
python -m sentinel_xdr_migration.arm_workbook_deployment plan|review|execute, separate from extension-direct dispatch and all-content acceptance. Current clean authored review receipts and existing V3.1 package projection/exact versioned ZIP checks remain mandatory. Bind original and semantic-compact template hashes, parameter/request hashes, package identity, exact target, delegated ARM user object ID, CLI/profile and every effective resource to user review and immediate confirmation.Only DeployDefenderWorkbook is true; every other declared Deploy* flag is explicitly false. Enumerate unconditional registrations and nested deployments, do not suppress them or pretend this is workbook objects only. Preserve public files, all strings/query whitespace, IDs and versions. Bound the full request including conservative CLI serialization to 4 MiB.
Execution checks the existing account/token and live workspace identity, reruns exact-byte Provider validation, durably reserves one attempt, then submits the whole template via authenticated Azure CLI
az restto normal resource-group Deployments PUT. ARM owns nested preview-provider execution; the toolkit makes no extension-direct authentication claims. Poll the exact ARM deployment record; only terminal Succeeded without errors passes. Errors/unknown outcomes remain durable and block blind retry.No existing workflow gate is completed/imported by this receipt. Installation, repeat-install/update, extension-direct contract, runtime/UI and completed Qualification remain unverified. No Graph/AH credential reuse, sign-in, grants, active rule deployment, ingestion or browser operations. Canonical docs distinguish the routes.
Verification / limitations
git diff --checkpassed.No Azure cloud resource write/deployment was performed. Earlier Provider validation is permission/template evidence, not successful write. Actual execution still requires exact-scope user approval and immediate confirmation, then live ARM success; workbook installation/readback and runtime qualification remain separate.