Persist and synchronize range-scoped fingerprint approvals - #19
Merged
Merged
Conversation
kilo666mj
changed the title
kilo666mj
marked this pull request as ready for review
September 28, 2026 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoped approvals now persist a validated set of client CIDRs alongside a fingerprint verdict. Status, label, scope and synchronization cursor commit atomically, preventing transient unrestricted approvals and partial policy batches. Legacy rows remain unrestricted; old setters cannot silently remove a scope.
The shared approval package normalizes IPv4/IPv6 prefixes and rejects malformed/empty scopes. Gates must explicitly advertise enforcement capability before accepting restricted policy. Documentation covers mixed-version rollout and downgrade hazards.
Validation: full Go tests, race tests and vet; legacy migration, restart, failed-transaction rollback, malformed-policy rejection and real TLSGate forwarding tests against this module; unchanged SSHGate consumer checked; source documentation validator passes. No production fingerprint changes are included.