Repository navigation
Fiddle: Add timeoutSeconds to RestEthClient - #169
Merged
Merged
Conversation
krishan711
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
timeoutSeconds(default 10, unchanged behaviour) toRestEthClient, so a client can use a shorter per-request timeout than the hardcoded 10s.Why: in YieldSeeker the Base archive node (Alchemy) timed out at 10s per call for ~8 hours overnight; every worker message waited through several of those timeouts, so the queue crawled. The app will give its archive client a shorter timeout so a degraded archive node fails fast.
core/web3/eth_client.py: newtimeoutSecondsinit arg, passed torequester.post_jsonUsed by https://github.com/tokenpage/yieldseeker-app/pull/842