ci: release 1.29.1 - #124
Merged
Merged
Conversation
The dependencies-apt cache is keyed on the runner label alone, so a build job can restore a deb set that prepare-apt downloaded on a different runner image. During an image rollout the two disagree on preinstalled library versions and 'dpkg -i' aborts on a versioned dependency -- ubuntu-22.04 image 20260831.284 carries libevent-core 2.1.12-stable-1build3 while the cached libevent-dev from image 20260907.292 requires 2.1.12-stable-1ubuntu0.1. Follow the dpkg install with 'apt-get install -f' so apt fetches whatever the cached debs are missing, keeping the cache's speed without depending on the two jobs landing on identical images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream surface review (1.29.0 -> 1.29.1)
onnxruntime_c_api.h,onnxruntime_cxx_api.handonnxruntime_cxx_inline.hare byte-identicalbetween v1.29.0 and v1.29.1. No new element data types, no new
GraphOptimizationLevel/ExecutionModemembers, no newOrt::SessionOptionssetter. Nothing to mirror.kOrtSessionOptionsGqaValueLayout("session.gqa_value_layout", valuesBNSH/BNHS) — new in1.29.1 for the GroupQueryAttention BNHS Value KV-cache layout. Not implemented as a typed option:
apply_session_options'config_entriespassthrough already forwards arbitrary keys verbatim andechoes them back through
GetSessionConfigEntry, so the key is reachable over the API today. Leftout of the
docs/swagger/openapi.yamlexample list because that example documents the passthroughmechanism, not a catalogue of ORT keys.
kOrtEpDevice_EpMetadataKey_GqaPreferredValueLayout("gqa_preferred_value_layout") — OrtEpDevicemetadata key. Not applicable: the server does not expose EP device metadata.
test/sample-onnx-generator/*.pyopset pins stay as they are.onnxruntime-linux-x64-gpu_cuda12-<VER>.tgz); no install-script,dockerfile, or
.github/actions/download-onnxruntime-*.shchange needed.Version-pinned assumptions re-validated (still true at 1.29.1)
src/onnx/value_info.cpp:203/unit_test_value_info.cpp:249— uint2 still stored unpacked, onevalue per byte; the
sample-datatypes.pypacked-uint2 tripwire did not fire in ctest.src/onnx/value_info.cpp:275/unit_test_value_info.cpp:284— complex64/128 tensors still notallocatable by ORT; the defensive decoder branches stay defensive.
Test plan