ci: release 1.29.0 - #123
Merged
Merged
Conversation
Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
ONNX Runtime 1.29 added POSIX telemetry, and the official linux-x64 binaries this project ships against are built with it enabled: the 1DS collector URL and ingestion token are present in libonnxruntime.so, PosixTelemetry::enabled_ defaults to true, and LogSessionCreation reports the model file name, graph name, producer, metadata map and execution provider ids. Since model name and version are user-chosen path components in --model-dir, that means deployment-specific names leave the process by default. Document the behaviour and the ORT_DISABLE_TELEMETRY opt-out in the README options section and on the Docker Hub page. The published images keep upstream's default rather than overriding it, so this is documentation only. The wording says "1.29" rather than "1.29.0" on purpose: deploy/update-version.sh runs a global sed of the old version string over both files, so a full version literal here would be silently rewritten by the next release. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream surface review (1.28.0 -> 1.29.0)
Header diff over
include/onnxruntime/core/session/*.hplus the 1.29.0 release notes.No new element data types, enum members, or public headers.
ONNXTensorElementDataType,GraphOptimizationLevelandExecutionModeare unchanged, sovalue_info::type_name,parse_graph_opt_levelandparse_execution_modestay complete.No ONNX / opset bump. 1.28.0 moved to ONNX 1.22.0; 1.29.0 does not move it again, so
sample-datatypes.pystays on opset 23.4 new session-config key macros (
kOrtSessionOptionEpEnableWeightless,kOrtSessionOptionEpContextSourceModelPath,kOrtSessionOptionsMaxShapeOverride,kOrtEpDevice_EpMetadataKey_WeightlessSupport) — nothing to implement:config_entriesalready forwards arbitrary keys toAddSessionConfigEntryand echoes theGetSessionConfigEntryreadback.ORT_INTRA_OP_NUM_THREADS/ORT_INTER_OP_NUM_THREADS(#29688) are process env vars for default pool sizes. Not applicable — explicitintra_op_num_threads/inter_op_num_threadsstill take precedence, and we always set them explicitly when the caller asks.Version-pinned assumptions re-verified against 1.29.0 (commit
a4d7ab7): packed uint2 initializers are still mis-loaded (theAllDataTypesModeltripwire did not fire, despite the packed sub-byteOrtApi::GetValuefix in #29157), and complex64/128 tensors still cannot be allocated. Both claims still hold; only the version named in the comments changed.POSIX telemetry is new in 1.29.0 (#27379) and is enabled in the official linux-x64 binary we ship against — documented in commit
47a2b33, images unchanged. Verified rather than assumed:https://mobile.events.data.microsoft.com/OneCollector/1.0and its ingestion token are present as literals in the shippedlibonnxruntime.so;PosixTelemetry::enabled_defaults totrue(core/platform/posix/telemetry.cc:84);ORT_DISABLE_TELEMETRY,ORT_RUNNING_UNIT_TESTS, or a CI env var (core/platform/telemetry_environment.h) — none of which a production container sets;LogSessionCreationreportsmodelFileName,modelGraphName, producer, domain, weight type, graph/weight hashes, the fullmodelMetaDatamap andexecutionProviderIds.Since
modelandversionare user-chosen path components under--model-dir, deployment-specific names leave the process by default. Decision: document, do not override. The published images keep upstream's default; the README options section and the Docker Hub page now describe the behaviour and theORT_DISABLE_TELEMETRYopt-out. BakingENV ORT_DISABLE_TELEMETRY=1into the dockerfiles remains open as a separate policy change.Test plan