ci: release 1.28.0 - #122
Merged
Merged
Conversation
GraphOptimizationLevel has ORT_ENABLE_LAYOUT (3) between ORT_ENABLE_EXTENDED and ORT_ENABLE_ALL, but parse_graph_opt_level had no string for it, so the level was unreachable from a session-create request and the key was silently dropped from the echo.
…o aarch64 tgz onnxruntime 1.28.0 uploaded the SBOM folder as onnxruntime-linux-aarch64.zip instead of the onnxruntime-linux-aarch64-1.28.0.tgz its own manifest lists, so the release carries no usable aarch64 archive and the arm64 leg of the linux-cpu image cannot resolve one. Fall back to the Microsoft.ML.OnnxRuntime nupkg, which ships that same CPU build under runtimes/linux-arm64 with an identical header set, and restore the libonnxruntime.so.1 SONAME link the flat nupkg layout omits. The tgz branch takes over again as soon as the release asset is fixed. Also make a missing archive fail the script: it previously fell through to wget/tar on an empty filename, exited 0, and left the failure to surface as a confusing cmake error further down the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"layout"forsession_options.graph_optimization_level, soORT_ENABLE_LAYOUTis reachable.Upstream 1.28.0 review
Checked the 1.28.0 release notes and diffed the 1.27.1 vs 1.28.0 headers for anything the server has to handle:
ONNXTensorElementDataTypeis unchanged from 1.27.1. No new packed/sub-byte type to unpack;value_info.cppalready covers the full enum.OrtErrorCode— moved to a newonnxruntime_error_code.hand gainedORT_DEVICE_RESET. The server never inspectsOrtErrorCode(it only catchesOrt::Exception), so nothing to wire up. Recovering a cached session after a device reset would be a separate feature.session.intra_op_num_threads,session.execution_mode,session.graph_optimization_level, …) plussession.name_based_layer_assignment. All are already reachable through the existing genericconfig_entriespassthrough, so no new typed fields were added.GraphOptimizationLevel—parse_graph_opt_levelwas missing a string forORT_ENABLE_LAYOUT(a pre-existing gap, not new in 1.28.0). Added"layout"with a unit test and the openapi enum entry.Broken upstream aarch64 asset
ONNX Runtime 1.28.0 does not ship a usable Linux aarch64 archive. Where 1.27.1 published a 7 MB
onnxruntime-linux-aarch64-1.27.1.tgz, 1.28.0 publishes a 350 KBonnxruntime-linux-aarch64.zipthat contains only_manifest/spdx_2.2/— no libraries, no headers, no nested archive. That SBOM's own file list names./onnxruntime-linux-aarch64-1.28.0.tgz, so the packaging pipeline built the right artifact and the upload step published the manifest folder in its place.download-onnxruntime.shnow falls back to theMicrosoft.ML.OnnxRuntimenupkg for linux/aarch64, which ships the same CPU build underruntimes/linux-arm64(verified: ELF aarch64, version string1.28.0, header file set identical to the official tarball). The nupkg lays the library out flat aslibonnxruntime.sowhile its SONAME islibonnxruntime.so.1, so the script recreates that link — the target stage only copies the directory and never runsldconfig. The tgz branch takes over again as soon as upstream fixes the asset.The script also used to fall through to
wget/taron an empty filename and exit 0 when no archive matched, surfacing the failure later as a confusing cmake error; a missing archive now fails it directly.Test plan
download-onnxruntime.sh linux x64(tgz) andlinux aarch64(nupkg fallback) both verified end to end into a sandboxed prefix.