Add vessel-graph connected-component labeling and node annotation rule#169
Draft
Copilot wants to merge 3 commits into
Draft
Add vessel-graph connected-component labeling and node annotation rule#169Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/khanlab/SPIMquant/sessions/1da3e99d-a7e3-4503-9a58-4625aeaefe07 Co-authored-by: akhanf <11492701+akhanf@users.noreply.github.com>
Agent-Logs-Url: https://github.com/khanlab/SPIMquant/sessions/1da3e99d-a7e3-4503-9a58-4625aeaefe07 Co-authored-by: akhanf <11492701+akhanf@users.noreply.github.com>
Agent-Logs-Url: https://github.com/khanlab/SPIMquant/sessions/1da3e99d-a7e3-4503-9a58-4625aeaefe07 Co-authored-by: akhanf <11492701+akhanf@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
akhanf
May 18, 2026 23:22
View session
Member
|
This ends up being too memory inefficient - ideally should move to using cugraph to do this, making use of a GPU -- however, currently dask-cuda pins to an older version of dask than zarrnii (zarrnii is pinned to newer version to support sharding).. so may need to 1) implement the vessel graph processing in a distinct conda env for now, 2) fork dask-cuda and remove the pin, or 3) wait for next dask-cuda release where the pin will move. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vessel nodes/edges are now generated, but nodes lacked graph connectivity context. This change adds a workflow step that computes connected components from the vessel graph and annotates each node with a component label ranked from largest to smallest.
Workflow graph updates
vessel_graph_to_nodes_edgesnow emitsnodes_raw.parquet+edges.parquetvessel_graph_connected_componentsconsumesnodes_raw.parquet+edges.parquetand writes finalnodes.parquetnodes.parquet) while introducing an explicit intermediate node table.Connected-components annotation
spimquant/workflow/scripts/annotate_vessel_graph_connected_components.py.src_node_id/dst_node_idand addscomponent_labelto nodes.1 = largest), with deterministic tie-break by minimumnode_id.Compatibility + robustness
convert_vessel_graph_to_nodes_edges.pyto support both output contracts (nodes_raw_parquetpreferred,nodes_parquetfallback) for backward compatibility.