Repository navigation
fix(kiosk): a finished timer stays in its pane and goes with one tap; its close button is clear of the dashboard's; kiosk 0.2.2 - #453
Merged
Conversation
… its close button is clear of the dashboard's; kiosk 0.2.2 A finished timer was a full-screen layer inside the kiosk page. In the dashboard's Talk to Crow overlay its close button sat exactly under the overlay's own close button, and the layer covered the bird and the talk button, so the only control left closed the whole overlay and the timer came back on reopen. - the finished timer stays in its window pane; the page tint marks it - one tap anywhere on a finished timer dismisses it (the same server event as its close button); a second event from the same gesture is ignored - in session mode a window's close button sits at the card's top-left, clear of the dashboard's button whatever the status-bar inset - the talk button sits above the windows - a live headless-browser test checks the geometry and a real tap at phone, landscape and desktop sizes, and on a paired display
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
When a timer finished, the kiosk page turned its card into a full-screen layer. Opened from the dashboard ("Talk to Crow", the session overlay), this caused three problems:
The fix
Tests
tests/kiosk-timer-done-live.test.jsruns in a private headless browser. It covers the session overlay at 412x915, 915x412 and 1280x800, and a paired display at 800x480 and 412x915. It checks with real hit-testing that the card's close button, the bird and the talk button are each reached by a tap at their center, and that no column is shared with the overlay's button. A real click on the card dismisses it once. Against the previous page code every case fails.tests/kiosk-page.test.js: tap-to-dismiss, the dismiss happening only once, the page tint, and the CSS rules.