Repository navigation
fix(media): the tab row wraps on a narrow screen instead of widening the page; media 1.1.3 - #451
Merged
Merged
Conversation
…the page; media 1.1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On a phone, the Media panel's tab row (Feed, For You, Playlists, Briefings, Podcasts, Folders, Sources, and the library tabs when installed) was a flex row that never wrapped. It was wider than the screen, so the whole dashboard page scrolled sideways and the cards below were cut off at the edge.
What changes
The tab row wraps (
flex-wrap: wrap) and carries amedia-tabsclass. media 1.1.3 so installed copies pick up the change; registry rebuilt.A broader pass over every panel at phone width (a shared guard and a regression test) is planned separately; this PR only fixes the reported page.
Tests
New test: the tab row wraps and holds every tab. Media panel tests 7/0, injection tests 15/0. Full suite: 7700 pass, 0 fail, 1 skipped. Registry and public hygiene checks pass.