feat(providers): external-engine provider kind — never orchestrated, read-only health, surfaced - #386
Merged
Merged
Conversation
added 11 commits
September 23, 2026 14:21
…ition-only validation, info-only surfacing, reconciler keeps marker)
… id, spread-safe malformed policies, EXTERNAL_ENGINE_-only per-row catches, lifecycle seam)
… warms, evicts or reverts to one
…conciler keeps the marker and isolates rows
…nitor notify cycle extracted and tested
…an external · host badge
…y poll, surfacing
- registerModel now refuses immediately when the existing row at a target provider id is an external engine (EXTERNAL_ENGINE_CONFLICT), before allocatePortFn/the conversions snapshot/the registry entry/saveState run — closing a leak where a contradictory replicated marker+bundle row could slip past the collision guard and reserve a port before upsertProvider's own validation caught it. - docs/architecture/models.md: correct the malformed-gpu_policy and unmark-then-register claims to match spec §2.2 and registerModel's actual behavior; note repairProviderHosts' per-row isolation. - tests/health-notify-cycle.test.js: neutralize CROW_BACKUP_DIR and the tailscale reader like external-engines-signal.test.js does. - Minor comment fixes: move providers-db.js's orphaned JSDoc onto assertExternalEngineWrite, note the belt-and-braces !p.disabled filter in external-engine-poll.js, document runHealthNotifyCycle in health-signals.js's header, and point the plan doc's operational check at /var/log/crow-inference/gateway.log instead of journalctl for crow-gateway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strix Halo track, sub-project 4. Crow now treats an externally operated engine as a first-class provider kind. The first case is halogen on raven (
http://10.0.0.126:8030/v1), and gufo is next if pi-lab's evaluation passes.docs/superpowers/specs/2026-09-23-external-engine-provider-design.mddocs/superpowers/plans/2026-09-23-external-engine-provider.md(two adversarial review rounds)What changes
gpu_policy.engine = {managed:"external", host, label}is an external engine. The marker replicates with the row, so every instance knows not to manage it.lifecycle.jscheck the marker first:ExternalEngineError;isAlwaysResidentis false, and the deferred set excludes it;upsertProviderrefuses writes that change engine,bundleIdor runtime into a contradictory state (EXTERNAL_ENGINE_CONFLICT/INVALID).syncProvidersFromModelsJsonandrepairProviderHostsisolateEXTERNAL_ENGINE_*errors per row and rethrow everything else.registerModelrefuses a marked row before any state is written.GET <base_url>/modelsevery 60 s (CROW_EXTERNAL_ENGINE_POLL_MS) and records the result in a newexternalmap inprovider-health.externalEngines, is info at most and never warns or pushes. External engines stop for hours during raven windows by design, and Crow is not their operator.providerssignal is byte-identical, and a regression test covers the push path: with a shared id, the dedupe would have suppressed real resident pushes.runHealthNotifyCyclewithout changing its behaviour.Rollout
raven-flash-nextgets marked, viaupsertProvideron crow. It replicates through the sync outbox.raven-halogen-smokepoints at a dead port (:8731) and stays unmarked, pending Kevin's call.Verification
state.jsonon a timer.check-portspasses.