fix: embed plugin migrations in binary — fixes 0/0 status and entity errors

Root cause: plugin migrations used relative filesystem paths
(internal/plugins/*/migrations/) that only resolve when CWD is the project
root. In Docker, the binary runs from /app so migrations were never found,
tables were never created, and entity pages crashed on missing tables.

Fix: each plugin now embeds its migrations/*.sql via Go's embed.FS. The
migration system reads from the embedded FS instead of the filesystem,
making it work regardless of working directory or deployment method.

Changes:
- Add embed.go to each plugin (calendar, maps, sessions, timeline, syncapi)
- Replace PluginSchema.MigrationsDir (string) with MigrationsFS (fs.FS)
- Move RegisteredPlugins() from database pkg to cmd/server (avoids cycles)
- Pass PluginSchemas through App struct to database explorer
- parsePluginMigrations and LatestMigrationVersion now use fs.FS

https://claude.ai/code/session_01QJLkgjQDu5qohzJKGV4hj9

Author: claude

cmd/server/main.go

@@ -5,6 +5,7 @@ package main
 
 import (
 	"context"
+	"io/fs"
 	"log/slog"
 	"os"
 	"os/signal"
@@ -14,6 +15,11 @@ import (
 	"github.com/keyxmakerx/chronicle/internal/app"
 	"github.com/keyxmakerx/chronicle/internal/config"
 	"github.com/keyxmakerx/chronicle/internal/database"
+	"github.com/keyxmakerx/chronicle/internal/plugins/calendar"
+	"github.com/keyxmakerx/chronicle/internal/plugins/maps"
+	"github.com/keyxmakerx/chronicle/internal/plugins/sessions"
+	"github.com/keyxmakerx/chronicle/internal/plugins/syncapi"
+	"github.com/keyxmakerx/chronicle/internal/plugins/timeline"
 	"github.com/keyxmakerx/chronicle/internal/systems"
 
 	// Import system packages for their init() factory registrations.
@@ -56,9 +62,11 @@ func main() {
 
 	// --- Run Plugin Migrations ---
 	// Each plugin runs its own schema migrations independently. Failures
-	// disable the plugin instead of crashing the app.
+	// disable the plugin instead of crashing the app. Migrations are
+	// embedded in the binary via embed.FS so they work in any environment.
 	pluginHealth := database.NewPluginHealthRegistry()
-	pluginResults := database.RunPluginMigrations(db, database.RegisteredPlugins())
+	pluginSchemas := registeredPlugins()
+	pluginResults := database.RunPluginMigrations(db, pluginSchemas)
 	for _, r := range pluginResults {
 		pluginHealth.Register(r.Slug, r.Healthy, r.Error, r.Version, r.LatestVersion)
 	}
@@ -85,7 +93,7 @@ func main() {
 	}
 
 	// --- Create Application ---
-	application := app.New(cfg, db, rdb, pluginHealth)
+	application := app.New(cfg, db, rdb, pluginHealth, pluginSchemas)
 
 	// Register all routes (public, plugin, system, widget, API).
 	application.RegisterRoutes()
@@ -139,3 +147,24 @@ func setupLogging(cfg *config.Config) {
 
 	slog.SetDefault(slog.New(handler))
 }
+
+// registeredPlugins returns the list of built-in plugins with their embedded
+// migration filesystems. Each plugin embeds its own migrations/*.sql files
+// via Go's embed package, ensuring they're available in the compiled binary
+// regardless of working directory.
+func registeredPlugins() []database.PluginSchema {
+	mustSub := func(fsys fs.FS, dir string) fs.FS {
+		sub, err := fs.Sub(fsys, dir)
+		if err != nil {
+			panic("embedded migrations sub-dir: " + err.Error())
+		}
+		return sub
+	}
+	return []database.PluginSchema{
+		{Slug: "calendar", MigrationsFS: mustSub(calendar.MigrationsFS, database.PluginMigrationsSubdir)},
+		{Slug: "maps", MigrationsFS: mustSub(maps.MigrationsFS, database.PluginMigrationsSubdir)},
+		{Slug: "sessions", MigrationsFS: mustSub(sessions.MigrationsFS, database.PluginMigrationsSubdir)},
+		{Slug: "timeline", MigrationsFS: mustSub(timeline.MigrationsFS, database.PluginMigrationsSubdir)},
+		{Slug: "syncapi", MigrationsFS: mustSub(syncapi.MigrationsFS, database.PluginMigrationsSubdir)},
+	}
+}

internal/app/app.go

@@ -49,11 +49,15 @@ type App struct {
 	// PluginHealth tracks which built-in plugins have healthy schemas.
 	// Used during route registration to skip degraded plugins.
 	PluginHealth *database.PluginHealthRegistry
+
+	// PluginSchemas holds the registered plugin migration configurations.
+	// Used by the database explorer to re-run migrations on demand.
+	PluginSchemas []database.PluginSchema
 }
 
 // New creates a new App instance with the given dependencies and configures
 // the Echo server with global middleware and error handling.
-func New(cfg *config.Config, db *sql.DB, rdb *redis.Client, pluginHealth *database.PluginHealthRegistry) *App {
+func New(cfg *config.Config, db *sql.DB, rdb *redis.Client, pluginHealth *database.PluginHealthRegistry, pluginSchemas []database.PluginSchema) *App {
 	e := echo.New()
 
 	// Disable Echo's default banner and startup message -- we log our own.
@@ -76,7 +80,8 @@ func New(cfg *config.Config, db *sql.DB, rdb *redis.Client, pluginHealth *databa
 		DB:           db,
 		Redis:        rdb,
 		Echo:         e,
-		PluginHealth: pluginHealth,
+		PluginHealth:  pluginHealth,
+		PluginSchemas: pluginSchemas,
 	}
 
 	// Register global middleware in order of execution.

internal/app/routes.go

@@ -862,7 +862,7 @@ func (a *App) RegisterRoutes() {
 	adminHandler.SetHygieneScanner(hygieneScanner)
 
 	// Database explorer: schema visualization and migration management.
-	dbExplorer := admin.NewDatabaseExplorer(a.DB, a.PluginHealth)
+	dbExplorer := admin.NewDatabaseExplorer(a.DB, a.PluginHealth, a.PluginSchemas)
 	adminHandler.SetDatabaseExplorer(dbExplorer)
 
 	// Wire security event logging into the auth handler so logins, logouts,

internal/database/plugin_schema.go

@@ -8,9 +8,8 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
+	"io/fs"
 	"log/slog"
-	"os"
-	"path/filepath"
 	"regexp"
 	"sort"
 	"strconv"
@@ -23,9 +22,10 @@ type PluginSchema struct {
 	// Slug is the unique plugin identifier (e.g., "calendar", "maps").
 	Slug string
 
-	// MigrationsDir is the absolute or relative path to the plugin's
-	// migrations/ directory containing numbered SQL files.
-	MigrationsDir string
+	// MigrationsFS is an embedded filesystem containing the plugin's
+	// numbered SQL migration files. Using embed.FS ensures migrations
+	// are available regardless of the binary's working directory.
+	MigrationsFS fs.FS
 }
 
 // PluginMigrationResult holds the outcome of running a single plugin's
@@ -109,20 +109,13 @@ func ensurePluginSchemaTable(db *sql.DB) error {
 func runSinglePluginMigrations(db *sql.DB, plugin PluginSchema) PluginMigrationResult {
 	ctx := context.Background()
 
-	// Check if the migrations directory exists.
-	if _, err := os.Stat(plugin.MigrationsDir); err != nil {
-		if os.IsNotExist(err) {
-			// No migrations directory = nothing to do, plugin is healthy.
-			return PluginMigrationResult{Slug: plugin.Slug, Healthy: true, Version: 0}
-		}
-		return PluginMigrationResult{
-			Slug:  plugin.Slug,
-			Error: fmt.Errorf("checking migrations dir: %w", err),
-		}
+	if plugin.MigrationsFS == nil {
+		// No embedded migrations = nothing to do, plugin is healthy.
+		return PluginMigrationResult{Slug: plugin.Slug, Healthy: true, Version: 0}
 	}
 
-	// Parse migration files from disk.
-	migrations, err := parsePluginMigrations(plugin.MigrationsDir)
+	// Parse migration files from embedded filesystem.
+	migrations, err := parsePluginMigrations(plugin.MigrationsFS)
 	if err != nil {
 		return PluginMigrationResult{
 			Slug:  plugin.Slug,
@@ -192,10 +185,10 @@ func runSinglePluginMigrations(db *sql.DB, plugin PluginSchema) PluginMigrationR
 	}
 }
 
-// parsePluginMigrations reads numbered SQL migration files from a directory.
+// parsePluginMigrations reads numbered SQL migration files from an embedded filesystem.
 // Returns migrations sorted by version number ascending.
-func parsePluginMigrations(dir string) ([]pluginMigration, error) {
-	entries, err := os.ReadDir(dir)
+func parsePluginMigrations(migrationsFS fs.FS) ([]pluginMigration, error) {
+	entries, err := fs.ReadDir(migrationsFS, ".")
 	if err != nil {
 		return nil, fmt.Errorf("reading migrations dir: %w", err)
 	}
@@ -225,7 +218,7 @@ func parsePluginMigrations(dir string) ([]pluginMigration, error) {
 			pairs[version] = &migPair{}
 		}
 
-		content, err := os.ReadFile(filepath.Join(dir, entry.Name()))
+		content, err := fs.ReadFile(migrationsFS, entry.Name())
 		if err != nil {
 			return nil, fmt.Errorf("reading %s: %w", entry.Name(), err)
 		}
@@ -331,16 +324,13 @@ func splitPluginStatements(sql string) []string {
 }
 
 // LatestMigrationVersion returns the highest migration version number found
-// in a plugin's migrations directory. Returns 0 if no migrations exist.
-func LatestMigrationVersion(migrationsDir string) (int, error) {
-	if _, err := os.Stat(migrationsDir); err != nil {
-		if os.IsNotExist(err) {
-			return 0, nil
-		}
-		return 0, err
+// in a plugin's embedded migrations filesystem. Returns 0 if nil or empty.
+func LatestMigrationVersion(migrationsFS fs.FS) (int, error) {
+	if migrationsFS == nil {
+		return 0, nil
 	}
 
-	entries, err := os.ReadDir(migrationsDir)
+	entries, err := fs.ReadDir(migrationsFS, ".")
 	if err != nil {
 		return 0, err
 	}
@@ -366,14 +356,6 @@ func LatestMigrationVersion(migrationsDir string) (int, error) {
 	return highest, nil
 }
 
-// RegisteredPlugins returns the list of built-in plugins that have schema
-// migrations. The MigrationsDir paths are relative to the working directory.
-func RegisteredPlugins() []PluginSchema {
-	return []PluginSchema{
-		{Slug: "calendar", MigrationsDir: "internal/plugins/calendar/migrations"},
-		{Slug: "maps", MigrationsDir: "internal/plugins/maps/migrations"},
-		{Slug: "sessions", MigrationsDir: "internal/plugins/sessions/migrations"},
-		{Slug: "timeline", MigrationsDir: "internal/plugins/timeline/migrations"},
-		{Slug: "syncapi", MigrationsDir: "internal/plugins/syncapi/migrations"},
-	}
-}
+// PluginMigrationsSubdir is the subdirectory within each plugin's embed.FS
+// that contains migration SQL files (from //go:embed migrations/*.sql).
+const PluginMigrationsSubdir = "migrations"

internal/plugins/admin/database_service.go

@@ -80,15 +80,17 @@ type MigrationHistory struct {
 
 // databaseExplorer implements DatabaseExplorer with direct DB access.
 type databaseExplorer struct {
-	db           *sql.DB
-	pluginHealth *database.PluginHealthRegistry
+	db            *sql.DB
+	pluginHealth  *database.PluginHealthRegistry
+	pluginSchemas []database.PluginSchema
 }
 
 // NewDatabaseExplorer creates a new database explorer service.
-func NewDatabaseExplorer(db *sql.DB, pluginHealth *database.PluginHealthRegistry) DatabaseExplorer {
+func NewDatabaseExplorer(db *sql.DB, pluginHealth *database.PluginHealthRegistry, pluginSchemas []database.PluginSchema) DatabaseExplorer {
 	return &databaseExplorer{
-		db:           db,
-		pluginHealth: pluginHealth,
+		db:            db,
+		pluginHealth:  pluginHealth,
+		pluginSchemas: pluginSchemas,
 	}
 }
 
@@ -220,10 +222,9 @@ func (e *databaseExplorer) GetSchema(ctx context.Context) (*DatabaseSchema, erro
 
 // GetMigrationStatus computes the migration status for each registered plugin.
 func (e *databaseExplorer) GetMigrationStatus(ctx context.Context) ([]PluginMigrationStatus, error) {
-	plugins := database.RegisteredPlugins()
-	statuses := make([]PluginMigrationStatus, 0, len(plugins))
+	statuses := make([]PluginMigrationStatus, 0, len(e.pluginSchemas))
 
-	for _, p := range plugins {
+	for _, p := range e.pluginSchemas {
 		status := PluginMigrationStatus{
 			Slug:    p.Slug,
 			Healthy: true,
@@ -285,8 +286,7 @@ func (e *databaseExplorer) getMigrationHistory(ctx context.Context, slug string)
 // ApplyPendingMigrations runs all pending plugin migrations and updates the
 // health registry. Returns the results for each plugin.
 func (e *databaseExplorer) ApplyPendingMigrations(ctx context.Context) ([]database.PluginMigrationResult, error) {
-	plugins := database.RegisteredPlugins()
-	results := database.RunPluginMigrations(e.db, plugins)
+	results := database.RunPluginMigrations(e.db, e.pluginSchemas)
 
 	// Update the health registry with new results.
 	for _, r := range results {

internal/plugins/calendar/embed.go

@@ -0,0 +1,11 @@
+// Package calendar provides the calendar/events addon for campaigns.
+// This file embeds the plugin's SQL migration files so they are available
+// in the compiled binary regardless of the runtime working directory.
+package calendar
+
+import "embed"
+
+// MigrationsFS contains the embedded SQL migration files for the calendar plugin.
+//
+//go:embed migrations/*.sql
+var MigrationsFS embed.FS

internal/plugins/maps/embed.go

@@ -0,0 +1,11 @@
+// Package maps provides the interactive maps addon for campaigns.
+// This file embeds the plugin's SQL migration files so they are available
+// in the compiled binary regardless of the runtime working directory.
+package maps
+
+import "embed"
+
+// MigrationsFS contains the embedded SQL migration files for the maps plugin.
+//
+//go:embed migrations/*.sql
+var MigrationsFS embed.FS

internal/plugins/sessions/embed.go

@@ -0,0 +1,11 @@
+// Package sessions provides the game session tracking addon for campaigns.
+// This file embeds the plugin's SQL migration files so they are available
+// in the compiled binary regardless of the runtime working directory.
+package sessions
+
+import "embed"
+
+// MigrationsFS contains the embedded SQL migration files for the sessions plugin.
+//
+//go:embed migrations/*.sql
+var MigrationsFS embed.FS

internal/plugins/syncapi/embed.go

@@ -0,0 +1,11 @@
+// Package syncapi provides the sync API addon for campaigns.
+// This file embeds the plugin's SQL migration files so they are available
+// in the compiled binary regardless of the runtime working directory.
+package syncapi
+
+import "embed"
+
+// MigrationsFS contains the embedded SQL migration files for the syncapi plugin.
+//
+//go:embed migrations/*.sql
+var MigrationsFS embed.FS

internal/plugins/timeline/embed.go

@@ -0,0 +1,11 @@
+// Package timeline provides the timeline addon for campaigns.
+// This file embeds the plugin's SQL migration files so they are available
+// in the compiled binary regardless of the runtime working directory.
+package timeline
+
+import "embed"
+
+// MigrationsFS contains the embedded SQL migration files for the timeline plugin.
+//
+//go:embed migrations/*.sql
+var MigrationsFS embed.FS