fix: migration status showing 0/0 — store LatestVersion in health registry

LatestMigrationVersion() re-scans migration files from disk using relative
paths, which fail at runtime when the binary's CWD differs from the project
root. Fix by computing LatestVersion once at startup (when CWD is correct)
and storing it in both PluginMigrationResult and PluginHealthRegistry.

GetMigrationStatus() now reads LatestVersion from the registry instead of
re-scanning disk, making it work correctly in all environments.

https://claude.ai/code/session_01QJLkgjQDu5qohzJKGV4hj9

Author: claude

cmd/server/main.go

@@ -60,7 +60,7 @@ func main() {
 	pluginHealth := database.NewPluginHealthRegistry()
 	pluginResults := database.RunPluginMigrations(db, database.RegisteredPlugins())
 	for _, r := range pluginResults {
-		pluginHealth.Register(r.Slug, r.Healthy, r.Error, r.Version)
+		pluginHealth.Register(r.Slug, r.Healthy, r.Error, r.Version, r.LatestVersion)
 	}
 	if degraded := pluginHealth.DegradedPlugins(); len(degraded) > 0 {
 		slog.Warn("some plugins are degraded — features disabled",

internal/database/plugin_health.go

@@ -20,6 +20,9 @@ type PluginHealth struct {
 	// Version is the highest applied migration version for this plugin.
 	Version int
 
+	// LatestVersion is the highest available migration version from disk.
+	LatestVersion int
+
 	// UpdatedAt is when this status was last set.
 	UpdatedAt time.Time
 }
@@ -41,14 +44,15 @@ func NewPluginHealthRegistry() *PluginHealthRegistry {
 
 // Register records the health status of a plugin. Called once per plugin
 // during startup after migrations complete (or fail).
-func (r *PluginHealthRegistry) Register(slug string, healthy bool, err error, version int) {
+func (r *PluginHealthRegistry) Register(slug string, healthy bool, err error, version int, latestVersion int) {
 	r.mu.Lock()
 	defer r.mu.Unlock()
 
 	h := PluginHealth{
-		Healthy:   healthy,
-		Version:   version,
-		UpdatedAt: time.Now(),
+		Healthy:       healthy,
+		Version:       version,
+		LatestVersion: latestVersion,
+		UpdatedAt:     time.Now(),
 	}
 	if err != nil {
 		h.Error = err.Error()

internal/database/plugin_schema.go

@@ -31,10 +31,11 @@ type PluginSchema struct {
 // PluginMigrationResult holds the outcome of running a single plugin's
 // schema migrations.
 type PluginMigrationResult struct {
-	Slug    string
-	Healthy bool
-	Error   error
-	Version int
+	Slug          string
+	Healthy       bool
+	Error         error
+	Version       int
+	LatestVersion int
 }
 
 // pluginMigration represents a single numbered migration for a plugin.
@@ -130,15 +131,19 @@ func runSinglePluginMigrations(db *sql.DB, plugin PluginSchema) PluginMigrationR
 	}
 
 	if len(migrations) == 0 {
-		return PluginMigrationResult{Slug: plugin.Slug, Healthy: true, Version: 0}
+		return PluginMigrationResult{Slug: plugin.Slug, Healthy: true, Version: 0, LatestVersion: 0}
 	}
 
+	// Compute the highest available migration version from files.
+	latestVersion := migrations[len(migrations)-1].Version
+
 	// Get already-applied versions.
 	applied, err := getPluginAppliedVersions(ctx, db, plugin.Slug)
 	if err != nil {
 		return PluginMigrationResult{
-			Slug:  plugin.Slug,
-			Error: fmt.Errorf("reading applied versions: %w", err),
+			Slug:          plugin.Slug,
+			LatestVersion: latestVersion,
+			Error:         fmt.Errorf("reading applied versions: %w", err),
 		}
 	}
 	appliedSet := make(map[int]bool, len(applied))
@@ -165,9 +170,10 @@ func runSinglePluginMigrations(db *sql.DB, plugin PluginSchema) PluginMigrationR
 		// code, so we skip the SQL validator (unlike user extensions).
 		if err := execPluginMigration(ctx, db, plugin.Slug, m); err != nil {
 			return PluginMigrationResult{
-				Slug:    plugin.Slug,
-				Error:   err,
-				Version: highestVersion,
+				Slug:          plugin.Slug,
+				Error:         err,
+				Version:       highestVersion,
+				LatestVersion: latestVersion,
 			}
 		}
 
@@ -179,9 +185,10 @@ func runSinglePluginMigrations(db *sql.DB, plugin PluginSchema) PluginMigrationR
 	}
 
 	return PluginMigrationResult{
-		Slug:    plugin.Slug,
-		Healthy: true,
-		Version: highestVersion,
+		Slug:          plugin.Slug,
+		Healthy:       true,
+		Version:       highestVersion,
+		LatestVersion: latestVersion,
 	}
 }
 

internal/plugins/admin/database_service.go

@@ -229,23 +229,15 @@ func (e *databaseExplorer) GetMigrationStatus(ctx context.Context) ([]PluginMigr
 			Healthy: true,
 		}
 
-		// Get health from registry.
+		// Get health and version info from registry (populated at startup
+		// when migration files are scanned — avoids re-reading disk at runtime).
 		if h := e.pluginHealth.Get(p.Slug); h != nil {
 			status.Healthy = h.Healthy
 			status.CurrentVersion = h.Version
+			status.LatestVersion = h.LatestVersion
 			status.Error = h.Error
 		}
-
-		// Get latest available version from migration files.
-		latest, err := database.LatestMigrationVersion(p.MigrationsDir)
-		if err != nil {
-			slog.Warn("failed to read migration files",
-				slog.String("plugin", p.Slug),
-				slog.Any("error", err),
-			)
-		}
-		status.LatestVersion = latest
-		status.Pending = latest - status.CurrentVersion
+		status.Pending = status.LatestVersion - status.CurrentVersion
 		if status.Pending < 0 {
 			status.Pending = 0
 		}
@@ -298,7 +290,7 @@ func (e *databaseExplorer) ApplyPendingMigrations(ctx context.Context) ([]databa
 
 	// Update the health registry with new results.
 	for _, r := range results {
-		e.pluginHealth.Register(r.Slug, r.Healthy, r.Error, r.Version)
+		e.pluginHealth.Register(r.Slug, r.Healthy, r.Error, r.Version, r.LatestVersion)
 	}
 
 	return results, nil