Repository navigation
Pick the latest CVE ID when parsing SecAlert response - #83
Merged
Merged
Conversation
ahus1
approved these changes
Sep 1, 2026
ahus1
left a comment
ahus1
left a comment
Member
There was a problem hiding this comment.
Thank you, reviewing the test and the code looks good to me.
When a SecAlert reply subject references an old CVE (e.g., "Incomplete fix for CVE-2026-9083") while the body contains the newly assigned CVE, the bot picked the wrong one. Now collects all CVE IDs from both subject and body, and selects the one with the highest sequence number. Closes keycloak#80 Signed-off-by: Bruno Oliveira da Silva <bruno@abstractj.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a SecAlert reply subject references an old CVE (e.g., "Incomplete fix for CVE-2026-9083") while the body contains the newly assigned CVE, the bot picked the wrong one. Now collects all CVE IDs from both subject and body, and selects the one with the highest sequence number.
Closes #80