Skip to content

test: migrate test suite to package:checks#102

Merged
kevmoo merged 1 commit into
masterfrom
migrate_to_checks
Jun 9, 2026
Merged

test: migrate test suite to package:checks#102
kevmoo merged 1 commit into
masterfrom
migrate_to_checks

Conversation

@kevmoo

@kevmoo kevmoo commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Migrates the test suite from package:matcher to package:checks.

Verified 100% clean static analysis (dart analyze) and all tests passing (dart test).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the test suite from using standard package:test assertions to the package:checks library. It adds checks as a dev dependency, updates test imports to use package:test/scaffolding.dart and package:checks/checks.dart, and rewrites the assertions across several test files to use the new check API. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kevmoo

kevmoo commented Jun 9, 2026

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the test suite from using standard expect assertions to the package:checks library. It adds checks to the development dependencies in pubspec.yaml and updates the assertions across several test files (command_test.dart, dhttpd_test.dart, ensure_build_test.dart, and utils_test.dart) to use the new check API. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kevmoo

kevmoo commented Jun 9, 2026

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the test suite from using standard package:test assertions (expect) to the modern package:checks library. It adds checks as a dev dependency in pubspec.yaml and updates imports and assertions across multiple test files, including command_test.dart, dhttpd_test.dart, ensure_build_test.dart, and utils_test.dart. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kevmoo kevmoo merged commit 32ac414 into master Jun 9, 2026
6 checks passed
@kevmoo kevmoo deleted the migrate_to_checks branch June 9, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant