Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2.0.0: removes what 1.4 announced with deprecation notices, inserts values as text by default, and
fixes the three bugs whose fixes change output. Stays a draft until the release; the version is
2.0.0-devuntil then.Packaging:
CI matrix: jQuery 3.5.1, 3.7.1 and 4.0.0 (was 1.7.2, 3.7.1, 4.0.0) on Chromium, Firefox and WebKit.
Docs:
docs/migrating-to-2.md(each 1.4 notice quoted, with its replacement), guides rewrittenfor 2.0,
docs/debugging.mdremoved, the two connected-select examples load each select directly.Evidence
src/published as 1.4.0: 125/125 (jQuery 3.7.1 and 4.0.0).After: this branch's suite against 1.4.0: 19 failures on jQuery 3.7.1, 18 on 4.0.0, each a
2.0 change with a migration guide entry; on this branch: 133/133 per browser, no
it.failsleft, 100% coverage; jQuery 3.5.1 / 3.7.1 / 4.0.0 × Chromium / Firefox / WebKit and the end-to-end
tests pass locally.
test/surfaces/exports.test.js) resolve with Node, asimportandrequire:jquery-load-json→.mjs/ classic build; the three dist files andpackage.jsonresolve;src/*.js,dist/jquery.loadJSONand the source map giveERR_PACKAGE_PATH_NOT_EXPORTED.With the
exportsmap removed, five of them fail.Merge Danger
Door: two-way until the tag; one-way once 2.0.0 is on npm.
Merging alone publishes nothing; the release is a separate tag and approval. After 2.0.0 is
published, its behavior can only be changed by later versions, and 1.x fixes come from
release/1.x.Blast Radius: consumers
Every user who upgrades across the major: values that held markup show as text, URL arguments
throw,
reltemplates stop matching, a second load restores the template (handlers bound inside itsince the first call are lost), deep imports of
src/stop resolving, and jQuery below 3.5 isunsupported.
^1ranges are unaffected.🤖 Generated with Claude Code