Repository navigation
1.4.0: tests, modern tooling, jQuery 4 support and fixes - #39
Merged
Merged
Conversation
…ith Rollup The body now uses the jQuery it is given, so CommonJS no longer needs a global jQuery.
Removes Grunt, .editorconfig, and the old issue template and CodeQL workflow ahead of their replacements.
License id LGPL-2.1-or-later, jquery >=1.7 as on npm, entry points and files list for the Rollup build.
CI runs npm test plus the suite and e2e tests on jQuery 1.7.2, 3.7.1 and 4.0.0 in three browsers.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
…the original data explicitly
…the original data
…uired without a window
…tching and notices
…b Pages GitHub Pages serves only docs/; CI checks the copy matches dist/.
Ports eight of the old examples; the Bing Maps and jQuery Mobile pages are not ported.
The old examples/ ignore pattern also matched docs/examples/, so Prettier had skipped them.
docs/examples replaces them; this clears the code-scanning alerts they raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.4.0: a non-breaking release. Same
$.fn.loadJSON(data, options)API, same jQuery support (1.7+), now also jQuery 4. It supersedes 1.3.4, which was tagged on GitHub but never published to npm.Summary
Fixes, compared with 1.3.3 on npm:
JSON.parseinstead of the removed$.parseJSON), and CommonJS without a window builds jQuery 4 fromjquery/factory.src;{src, alt, title}sets all three on that image.#fragment, and anhrefthat is only a query gets&.a:b() match by attribute instead of throwing or missing.nullvalues are skipped instead of throwing.Array.prototype.containsis no longer enumerable, so it stays out offor...inloops.import "jquery-load-json"registers the plugin. Thebrowserfield pointed bundlers that read it first at the classic build, which never registered it.New:
$.fn.loadJSON.debug = trueshows a console warning, once per page, for each behavior 2.0 removes (docs/debugging.md). Off by default, so output is unchanged.Project: tests, Rollup build, ESLint and Prettier, CI on jQuery 1.7.2, 3.7.1 and 4.0.0 in Chromium, Firefox and WebKit, CodeQL, a release workflow publishing to npm through trusted publishing with provenance, docs in
docs/with working examples, SRI hashes on the CDN snippets, license idLGPL-2.1-or-later,jqueryback to>=1.7as on npm today.Evidence
After:
npm testpasses: 143 tests, 100% statement, branch, function and line coverage (enforced), and the four bugs left for 2.0 recorded as expected failures. All 9 jQuery x browser cells and the end-to-end tests pass in CI.browserfirst (rolldown) bundled the classic build, andtypeof $.fn.loadJSONwas"undefined".After: it bundles
dist/jquery.loadJSON.mjs, andtypeof $.fn.loadJSONis"function"(test/surfaces/bundlers.test.js).Merge Danger
Door: two-way
Merging publishes nothing; the
v1.4.0tag does, after approval. Once on npm, 1.4.0 cannot be unpublished and republished under the same version; a regression ships as 1.4.1.Blast Radius: consumers
mainmoves fromsrc/todist/jquery.loadJSON.js. A deep import ofsrc/jquery.loadJSON.jsnow gets an ES module that imports its sibling files.docs/and the examples frommain.🤖 Generated with Claude Code