Feat: send input files ref to kcidb, add input files to maestro "artifacts" field#1140
Open
tollsimy wants to merge 4 commits intokernelci:mainfrom
Open
Feat: send input files ref to kcidb, add input files to maestro "artifacts" field#1140tollsimy wants to merge 4 commits intokernelci:mainfrom
tollsimy wants to merge 4 commits intokernelci:mainfrom
Conversation
tollsimy
force-pushed
the
feat/input-files
branch
3 times, most recently
from
a01d1d5 to
5497db3
Compare
nuclearcat
added
the
staging-skip
tales-aparecida
approved these changes
Jun 9, 2025
tales-aparecida
left a comment
tales-aparecida
left a comment
There was a problem hiding this comment.
I have some nitpicking, which you can select on your discretion, but consider also that we could, otherwise, rename _get_output_files to something like _filter_artifacts and pass
exclude_properties=[f"input_{i}" for i in INPUT_FILE_TYPES] to avoid adding the duplicated code within _get_input_files
tollsimy
force-pushed
the
feat/input-files
branch
from
5497db3 to
37ed033
Compare
Author
|
Thanks @tales-aparecida for the suggestions! |
tales-aparecida
requested changes
Jun 10, 2025
tales-aparecida
left a comment
tales-aparecida
left a comment
There was a problem hiding this comment.
Not to abuse your patience, but here's more nit picking
Signed-off-by: Simone Tollardo <tollsimy.dev@protonmail.com>
Signed-off-by: Simone Tollardo <tollsimy.dev@protonmail.com>
Signed-off-by: Simone Tollardo <tollsimy.dev@protonmail.com>
…ts input and output files Signed-off-by: Simone Tollardo <tollsimy.dev@protonmail.com>
tollsimy
force-pushed
the
feat/input-files
branch
from
91331a3 to
81ff54a
Compare
| parsed_test_node['output_files'] = self._get_output_files( | ||
| parsed_test_node['input_files'] = self._filter_artifacts( | ||
| artifacts=artifacts, | ||
| include_properties=('input_') |
There was a problem hiding this comment.
Suggested change
| include_properties=('input_') | |
| include_properties=('input_',) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complements what added in kernelci/kcidb-io#99 and kernelci/kcidb#635, allowing to send reference to input files to kcidb as well as input files to "artifacts" field in maestro.
This PR requires kernelci/kernelci-core#2872.