Conversation
Contributor
Author
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
CredentialForm.onSubmitpayload before fetch usingjosecompact JWE (ECDH-ES+A256KWwith P-256,A256GCM). authenticate the key ID, collection request ID, immutable item ID, and rendered version; bound envelope/plaintext sizes and preserve field validation.PrivateKeyProtectorboundary for production KMS/HSM integration.all changes are confined to this example. no Kernel API or
@onkernel/vault-reactchanges.validation
bun install --frozen-lockfilebun run typecheckbun run test— 24 tests, 173 assertions; real form-to-handler encryption, exact SDK forwarding, wrong/tampered keys/envelopes/bindings, size/field/lifecycle/origin checks, wrapped-key persistence/cleanup, concurrency, and uncertain outcomes.NEXT_TELEMETRY_DISABLED=1 bun run buildreview gate
CI passed on
ac1ccbb. Bugbot was explicitly requested but reported that it is disabled for this repository. The required Bugbot review is blocked until it is enabled; this PR has not received a green Bugbot result.boundaries and caveats
this protects submitted values from passive browser-to-backend HTTP-body capture, not from the trusted frontend, decrypt-and-forward handler, or Kernel. active script/key replacement and in-process instrumentation remain outside the guarantee. safe GET responses still include displayable non-sensitive saved values.
the file store/environment wrapping key are local-demo implementations. production needs KMS/HSM-equivalent wrapping, transactional storage/distributed claims, key rotation/retention, capture exclusions, and explicit uncertain-outcome reconciliation. there is no distributed transaction or exactly-once delivery claim. clearing current wrapped material does not erase backups or guarantee JavaScript memory zeroization. no live Kernel vault was modified during validation.