Repository navigation
feat(map): a shelving unit sized by width, depth, height and shelves - #538
Merged
Merged
Conversation
ibrahimroshdy
force-pushed
the
feat/shape-shelving-unit
branch
from
November 12, 2026 18:00
f9f2017 to
986f4de
Compare
…485) A new sized shape beside the cube storage and the tall bookcase: four steel posts and its shelves, open on every side, the bottom shelf 8 cm off the floor and the top one level with the posts. Its card takes Width, Depth and Height (30 to 240, 15 to 80 and 40 to 300 cm, inches in imperial) and Shelves, two at least and one every 15 cm at most; it starts at 90 x 50 x 180 cm with 5. The node's model carries the numbers (shelving_unit_120x60x200_4), so the layout, API and database check are unchanged. Furniture whose shelves match is drawn with a compartment on each shelf, the top one above it. It answers to shelving unit, storage shelf, garage and pantry shelving and their words in each language; plain "shelving" now suggests it beside the metal shelf. Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
…ery catalogue (#485) Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
… its compartment tests can fail (#485) Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
…es and inches in every language (#485) Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
…namese (#485) Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
ibrahimroshdy
force-pushed
the
feat/shape-shelving-unit
branch
from
November 13, 2026 00:42
986f4de to
4394d1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shelving unit sized by width, depth, height and number of shelves, from the request in #485.
Closes #485.
shelving_unit, a sized shape like cube storage and the tall bookcase: the numbers ride in the stored model (shelving_unit_120x60x200_4), so the layout format, API and database check are unchanged (the longest key fits the 40-character check).Not in this PR
The "Shelving unit" furniture template is still drawn as a bookcase: the map only knows a layout's kind, not which template made it. That needs a small server change; until then, pick "Shelving unit" on the card.
Definition of done
sized.test.ts(posts, spacing, one space per shelf),compartments.test.ts,size.test.tsx, the server layout test (stores the key, refuses bad ones) and history (a resize).map-shapes.mdxandlocation-map.mdxin every language, and the sized-shapes table inadd-a-shape.md.KEPT_*settings: n/a.Merges before or after the water purifier; whichever goes second regenerates the sprite (
node apps/web/scripts/render-map-thumbs.mjs).