Repository navigation
feat(map): a water purifier shape - #537
Merged
Merged
Conversation
A floor-standing water purifier in Kitchen and laundry: a dark cabinet on a recessed plinth with a brass band, a glass top with its buttons, and a back panel with a lit display, the tap and a handle. Drawn in code, nothing downloaded. It answers to the words the request gave in each language (water purifier, water filter, máy lọc nước, فلتر مياه, Wasserfilter and the rest) and to a floor water dispenser's. A filter cartridge is not given it by itself; the water tank keeps its own words. Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
… jugs, cartridges and pet fountains don't get it (#443) Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
…p at 1.10 m (#443) Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
…#443) Signed-off-by: Ibrahim Roshdy <22573766+ibrahimroshdy@users.noreply.github.com>
ibrahimroshdy
force-pushed
the
feat/shape-water-appliance
branch
from
November 12, 2026 18:00
0895cc6 to
0d910e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A water purifier shape for the map, from the request in #443.
Closes #443.
water_purifier, 31 x 36 x 129 cm (the issue gives no units; centimetres fit the numbers and the photos), in Kitchen and laundry. Drawn in code like the other shapes, with a new graphite material; the sprite is regenerated.Definition of done
map-shapes.test.ts(names in every language, search, the cartridge and tank cases) andmodels.test.ts(exactly 31 x 36 x 129 cm). Shared, web map and docs tests pass;check-i18npasses.KEPT_*settings: n/a.Merges before or after the shelving unit; whichever goes second regenerates the sprite (
node apps/web/scripts/render-map-thumbs.mjs).