Support matrix include and exclude expansions - #68
Draft
gjkim42 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api
What this PR does / why we need it:
Adds GitHub-compatible
strategy.matrix.includeandstrategy.matrix.excludetransformations. Exclusions remove partial matches before includes are applied;
includes can augment original combinations in declaration order or append
standalone combinations, and include-only matrices are supported.
The workflow parser now preserves axis declaration order, validates bounded
scalar transformation mappings, and applies the 256-job limit to the final
transformed set. Expanded values continue through the existing matrix expression
context and
WorkflowJob.spec.matrix.values, preserving stable child identity,max-parallelscheduling, and result aggregation.The previous matrix model decoded every matrix key as a scalar axis and only
computed a Cartesian product, so mapping-valued transformations were rejected.
Which issue(s) this PR is related to:
Fixes #65
Special notes for your reviewer:
This keeps matrix values scalar and does not change the WorkflowJob schema or
job-plan version. Strategy
fail-fastremains unsupported.Validation completed with
make testandmake verify.Does this PR introduce a user-facing change?