Complete runner context and support action defaults - #132
Conversation
|
/kelos claude-review |
|
🤖 Kelos Task Status Task |
|
🤖 Open Actions Claude Reviewer Agent @gjkim42 Review SummaryVerdict: APPROVE Findings Overview
FindingsNo qualifying findings. The previous review's P2 is resolved: docs/reference.md:318 now documents the case-insensitive masking exemption for secrets named Suggestions (optional)
Key takeaways
|
|
/kelos claude-review |
1 similar comment
|
/kelos claude-review |
54559d6 to
ffe97f8
Compare
|
/kelos claude-review |
Populate runner name, environment, and conditional debug values from trusted runner configuration. Evaluate action input defaults with the runner context, validate metadata expressions, and preserve GitHub debug control values in workflow output.
ffe97f8 to
36c3103
Compare
|
/kelos claude-review |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Completes the documented GitHub Actions
runnercontext and makes it available while evaluating action metadata input defaults.Open Actions now supplies:
runner.namefrom the assigned Kubernetes Runner resource, with the matching trustedRUNNER_NAMEdefault variable.runner.os,runner.arch,runner.temp, andrunner.tool_cachefrom the existing execution environment.runner.environmentasself-hosted, with matchingRUNNER_ENVIRONMENT, because Open Actions executes on user-managed infrastructure.runner.debugandRUNNER_DEBUGas1when theACTIONS_STEP_DEBUGProject secret or variable enables debug mode. The Secret takes precedence.Runner-owned values cannot be replaced by workflow environment mappings or inherited image configuration.
runner.debugandRUNNER_DEBUGremain absent when debug mode is disabled, matching GitHub Actions. Matching the GitHub Actions runner, theACTIONS_STEP_DEBUGandACTIONS_RUNNER_DEBUGsecret names are excluded from secret masking so their common value (true) does not mask logs or suppress job outputs.Action input defaults can read the complete runner context, so standard expressions such as
${{ runner.debug == '1' }}work withactions/github-script. The runner evaluates defaults only for inputs not supplied by the workflow while still validating every metadata default when loading the action.Coverage verifies controller-to-Pod name injection, CLI configuration, expression values, protected default variables, action-default evaluation and rejection, case-insensitive debug-secret masking exemptions, and an authenticated
actions/github-script@v7metadata fixture in normal and debug modes.Which issue(s) this PR is related to:
Fixes #39
Special notes for your reviewer:
GitHub documents
runner.debugandRUNNER_DEBUGas absent when debug logging is disabled, so this PR intentionally does not expose0in the disabled state. This completes the documented runner object; broader context work remains tracked by #110.Validated with:
make updatemake verifymake testmake buildDoes this PR introduce a user-facing change?