Skip to content

Remove pr-finish from self-development skills - #1632

Open
gjkim42 wants to merge 1 commit into
mainfrom
agent/remove-pr-finish-skill
Open

Remove pr-finish from self-development skills#1632
gjkim42 wants to merge 1 commit into
mainfrom
agent/remove-pr-finish-skill

Conversation

@gjkim42

@gjkim42 gjkim42 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The shared self-development AgentConfig installed the entire
gjkim42/kanon-repo skills package, which also made pr-finish available to
every self-development agent.

This PR replaces the package-wide installation with an explicit allowlist of
the five intended shared skills, leaving out pr-finish. It also updates the
self-development documentation and updater prompts to preserve individual
skill selection, and updates the manifest test to enforce the allowlist.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Validation:

  • make verify
  • make test TEST_FLAGS='-run TestSelfDevelopment'

The full make test run reached two unrelated Codex entrypoint test failures:
TestCodexEntrypointUsesPersistentSessionHome and the Codex case of
TestAgentEntrypointsPreserveSkillReferenceFiles. The changed
self-development tests pass.

Does this PR introduce a user-facing change?

NONE

Summary by cubic

Replaced the package-wide install of gjkim42/kanon-repo skills with an explicit allowlist to remove pr-finish from self-development agents. Updated docs and tests to reflect and enforce individual skill selection.

  • Refactors
    • base-agent.yaml now installs five skills explicitly: api-review, design-cleanup, gjkim-instruction, pre-session-end, review-all.
    • Updated README and updater prompts to reference selected shared skills instead of the full package.
    • Updated the self-development test to assert the exact allowlisted skills.

Written for commit 0839fbc. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant