Skip to content

Refine Kanon worker implementation guidance - #1255

Open
kelos-bot[bot] wants to merge 4 commits into
mainfrom
kanon-config-update-latest
Open

Refine Kanon worker implementation guidance#1255
kelos-bot[bot] wants to merge 4 commits into
mainfrom
kanon-config-update-latest

Conversation

@kelos-bot

@kelos-bot kelos-bot Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the task-specific kanon-workers prompt with two focused conventions backed by recurring review findings from Kanon implementation PRs.

First, the worker now tests every affected command, flag, scope, and guard outcome directly instead of relying on another path as indirect coverage:

Second, the worker now treats external repository inputs as one trust boundary across subprocess arguments, filesystem traversal, error output, and persistent caches:

  • Kanon PR Add axon CLI for managing Tasks #9 review found that a user-controlled repository value could be interpreted as a git option.
  • Kanon PR axon install/uninstall feature #29 reviews repeatedly found external-source boundary gaps: symlink traversal could read files outside the repository, expanded URL credentials could leak through git errors, and root clone metadata could persist credentials in the source cache.

Motivating reviews:

The rules remain in the implementation worker prompt because they address mistakes made while writing Kanon changes. Shared skills remain only in self-development/base-agent.yaml.

The audit did not promote Kanon PR #68's single README finding, Kanon PR #22's feature-specific schema findings, or Kanon PR #45's line-ending edge case into general rules. Other findings were already covered by Kanon's current repository instructions, including co-owned configuration preservation and resource-naming errors.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

There were no Kanon PRs updated or merged during the last-seven-days window of August 17-24, 2026. The newest PR activity in the requested recent-20 sets was July 25, 2026, and the newest merge was July 2, 2026. The audit therefore inspected the diffs, reviews, inline comments, and conversations for the review-bearing and generated-by-kelos PRs in those sets, while retaining the existing recurring evidence from PRs #9 and #16.

Only self-development/kanon/kanon-workers.yaml is changed. make verify passes.

Does this PR introduce a user-facing change?

NONE

@gjkim42 gjkim42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to refine kanon-development? self-development has the same instructions but it works fine.
/kelos pick-up

@kelos-bot

kelos-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Task Status

Task kelos-pr-responder-pull-request-review-658ffd796fb0 has succeeded. ✅

@kelos-bot
kelos-bot Bot force-pushed the kanon-config-update-latest branch from acb3127 to ec8dcdc Compare June 1, 2026 00:37
@kelos-bot kelos-bot Bot changed the title Make Kanon worker follow the PR template and label gates Give the Kanon worker standing PR-template guidance for the label gate Jun 1, 2026
@kelos-bot

kelos-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Agent @gjkim42

Good question — I dug into why self-development works without this and the answer points to a real gap rather than a redundancy:

kelos-workers complies with the PR template not because of its prompt, but because the kelos repo has a CLAUDE.md ("Always follow .github/PULL_REQUEST_TEMPLATE.md…"). That standing guidance is what clears the label gate. The kanon repo has no CLAUDE.md (verified via the GitHub API and a code search), so kanon-workers got no equivalent guidance from anywhere — and after kanon PR #8 added check-pr-labels, its PRs would trip the gate.

I've reworked the change to match how self-development does it: the convention now lives in the kanon-workers-agent agentsMD (the agent's standing instructions, the kanon analog of kelos's CLAUDE.md), and the numbered procedure steps are reverted to be identical to kelos-workers. Net diff is now just a 10-line ## Pull Requests section.

If you'd prefer this live in a CLAUDE.md added to the kelos-dev/kanon repo itself (which would also cover the other kanon agents and human contributors), I'm happy to open that as a follow-up against kanon instead — let me know.

@kelos-bot kelos-bot Bot changed the title Give the Kanon worker standing PR-template guidance for the label gate Give the Kanon worker PR-template and testing conventions Jun 1, 2026
@kelos-bot
kelos-bot Bot force-pushed the kanon-config-update-latest branch from 13e0c5f to 5f51b8c Compare July 14, 2026 18:35
@kelos-bot kelos-bot Bot changed the title Give the Kanon worker PR-template and testing conventions Refine Kanon worker test and documentation guidance Jul 14, 2026
@kelos-bot
kelos-bot Bot force-pushed the kanon-config-update-latest branch 2 times, most recently from 5d6d260 to 73efb00 Compare August 9, 2026 18:07
@kelos-bot kelos-bot Bot changed the title Refine Kanon worker test and documentation guidance Refine Kanon worker test coverage guidance Aug 21, 2026
@kelos-bot kelos-bot Bot changed the title Refine Kanon worker test coverage guidance Refine Kanon worker implementation guidance Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant