Skip to content

fix(siddur): scroll with the arrow keys and PageUp/PageDown - #749

Merged
kdroidFilter merged 1 commit into
masterfrom
fix/siddur-keyboard-scroll
Nov 1, 2026
Merged

kdroidFilter merged 1 commit into
masterfrom
fix/siddur-keyboard-scroll

Conversation

@kdroidFilter

Copy link
Copy Markdown
Owner

Closes #746

The smart siddur ignored the arrow keys and PageUp/PageDown, which scroll a book.

  • The siddur text's container takes the keys in preview, so they still work after a click selects in the text
  • Up/Down scroll 48dp at once (a held key repeats faster than an animation ends); PageUp/PageDown animate by 90% of the viewport
  • The text takes the focus when its tab is selected, so the keys work without a click first

Closes #746

Signed-off-by: Elie G. <elyahou.hadass@gmail.com>
@kdroidFilter
kdroidFilter merged commit 0d8f663 into master Nov 1, 2026
7 of 9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

בסידור החכם א"א לגלול עם החיצים [בשונה מהגלילה בספרים שכן מתאפשר עם החיצים]

1 participant