Repository navigation
fix(tabs): Ctrl+Tab follows the strip's right-to-left order - #748
Merged
Merged
Conversation
Since the tabs live in the Nucleus workspace, the group reads right to left from its end (index 0 is the leftmost tab), so Ctrl+Tab's index + 1 moved to the right, as in an LTR app. Ctrl+Tab now selects the tab on the left and Ctrl+Shift+Tab the one on the right, as Chrome does in Hebrew. Fixes #745 Signed-off-by: Elie G. <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #745.
Since the tabs moved to the Nucleus workspace (v0.6.12), a window's group reads right to left from its end: index 0 is the leftmost tab, new tabs go in at index 0, and pinned tabs are the last ones. Ctrl+Tab still selected
index + 1, which moved to the right, the LTR direction.MainAppWindownow go throughcycledTabIndex: Ctrl+Tab selects the tab on the left, Ctrl+Shift+Tab the one on the right, wrapping at both ends (as Chrome in Hebrew).CycledTabIndexTestcovers both directions, the wrap-around and a single tab.🤖 Generated with Claude Code