Repository navigation
feat(update): the Microsoft Store install updates from the Store - #747
Merged
Merged
Conversation
- Nucleus 3.0.0-dev-202610312124: the GraalVM AppX ships its own logos at every scale and target size (it had electron-builder's sample ones, rejected by the Store as generic), and jawt.dll, without which a Store-installed native image crashed at launch - the AppX asks the Store for updates (nucleus.microsoft-store) instead of the GitHub feed: always a prompt, the Store installs behind its dialog and Windows relaunches the app, a mandatory update opens the dialog; MINOR/MAJOR keep the database warning - the AppX logo sources at 1024 px, from which Nucleus makes every size Signed-off-by: Elie G. <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
appx { }logos topackageGraalvmAppX. Fixed in Nucleus (fix(plugin): the GraalVM AppX gets its logos, at every scale and target size NucleusFramework/Nucleus#894).jawt.dllnext to the exe; fixed in Nucleus (feat(microsoft-store): Microsoft Store purchases, app license, trial and updates NucleusFramework/Nucleus#891).What
3.0.0-dev-202610312124, with thenucleus.microsoft-storemodule.StoreUpdates(framework/update/StoreUpdates.kt): a seam overMicrosoftStore.updates, used byAppUpdateServicewhen the app runs as the Store's AppX (unless a feed is forced for QA). The GitHub feed path (NSIS, DMG/ZIP, Linux) is unchanged.major.minor.build.revisionis read asmajor.minor.patch; MINOR/MAJOR keep the database warning.desktopAppIcons/LinuxIcon.pngfor the app icon and the Store logo, padded 1024 / 1240×600 tiles): Nucleus now makes everyscale-*andtargetsize-*variant from them.Verification
StoreUpdatesTest(6): level from the Store's version, patch prompts without pre-download, mandatory opens the dialog, install progress, declined dialog, up to date and Store failure. The whole:SeforimApp:jvmTestpasses;ktlintCheckanddetektpass.packageGraalvmAppXwith the published Nucleus: the package carries Zayit's logos in 35 variants,resources.pri,jawt.dllandnucleus_msstore.dll.