Repository navigation
Conversation
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
coremarker toSubGroup(v2alpha2) so users choose which children of a SubGroupSet are part of a semi-preemptible PodGroup's core. Implements phase P1 of the HLD in kai-scheduler/KAI-Scheduler#2380.SubGroup.Core bool(json:"core,omitempty"), CRD regenerated.minSubGroup(unset = number of children; root uses the rootminSubGroup);coreon update of a semi-preemptible PodGroup (not enforced when the update leaves semi-preemptible);core: trueis set andpreemptibilityis notsemi-preemptible(ignored; marks are not counted in that case);No scheduler behavior change here; that is phase P2.
Related Issues
HLD: kai-scheduler/KAI-Scheduler#2380
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
None. The field is optional and ignored when unset.
Additional Notes
make generate,make manifests,make validate,make build,go test ./...pass.make clientswas not needed (no new types). Follow-up: a KAI-Scheduler PR repins to this commit until a tag is cut.