Repository navigation
fix(api): log PodGroup webhook updates at verbosity 4 - #24
Open
sam-huang1223 wants to merge 1 commit into
Open
sam-huang1223 wants to merge 1 commit into
sam-huang1223 wants to merge 1 commit into
Conversation
ValidateUpdate logged every PodGroup update at the default level. Updates happen throughout a PodGroup's life (status patches, controller reconciles), so on a busy cluster this line dominates the pod-group-controller log. Create and delete still log at the default level, as they happen once per PodGroup. Moves the webhook part of kai-scheduler/KAI-Scheduler#2309 here, as the pod-group-controller now registers this webhook from this module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Sam Huang <sam@Sams-MacBook-Pro-2.local>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PodGroup validating webhook logs
validate updateat the default level for every PodGroup update. Updates happen throughout a PodGroup's life (status patches, controller reconciles), so on a busy cluster this one line dominates the pod-group-controller log. This moves it to V(4).validate createandvalidate deletestay at the default level, since they happen once per PodGroup.This is the webhook part of kai-scheduler/KAI-Scheduler#2309. The pod-group-controller now registers this webhook from this module (kai-scheduler/KAI-Scheduler#1917), so the change belongs here; #2309 no longer touches the in-tree copy, which kai-scheduler/KAI-Scheduler#1928 removes.
Related Issues
Part of kai-scheduler/KAI-Scheduler#2308.
Checklist
TestValidateUpdateLogsAboveDefaultVerbositychecks thatvalidate updateis not logged at verbosity 3 and is logged at 4, whilevalidate createis still logged at 3. It fails with the line back at the default level.make changelogBreaking Changes
None. Operators who want the line back can raise the pod-group-controller's log verbosity to 4.
Additional Notes
go mod tidymovesgithub.com/go-logr/logrfrom indirect to direct, because the test builds afuncrlogger.make build test lintis clean.🤖 Generated with Claude Code