feat(k8s): add k8s_wait_for_condition tool#58
DCO
There are 10 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.
To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
Here is how to fix the problem so that this code can be merged.
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using
--allow-empty)
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~42 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feat/k8s-wait-for-condition
Summary
Commit sha: 0b4e7ab, Author: Ben Hirschberg, Committer: GitHub; Can not find "Ben Hirschberg 59160382+slashben@users.noreply.github.com", in ["Ben ben@armosec.io", "Ben ben@armosec.io", "Ben ben@armosec.io", "Ben ben@armosec.io", "Ben ben@armosec.io", "Ben ben@armosec.io"].
Commit sha: 0daa9ee, Author: Dmytro Rashko, Committer: GitHub; The sign-off is missing.
Commit sha: 62c4fba, Author: Jaison Paul, Committer: GitHub; Can not find "Jaison Paul 46974812+jsonmp-k8@users.noreply.github.com", in ["Jaison Paul paul.jaison@gmail.com", "Jaison Paul paul.jaison@gmail.com", "Eitan Yarmush eitan.yarmush@solo.io"].
Commit sha: e8c0b7c, Author: Jet Chiang, Committer: GitHub; Can not find "Jet Chiang jetjiang.ez@gmail.com", in ["Jet Chiang pokyuen.jetchiang-ext@solo.io", "Jet Chiang pokyuen.jetchiang-ext@solo.io", "Jet Chiang pokyuen.jetchiang-ext@solo.io"].
Commit sha: abdd0d5, Author: Matteo Mori, Committer: GitHub; Can not find "Matteo Mori 169821341+MatteoMori8@users.noreply.github.com", in ["Matteo Mori matteo.mori@rvu.co.uk", "Matteo Mori matteo.mori@rvu.co.uk", "Matteo Mori matteo.mori@rvu.co.uk"].
Commit sha: c315417, Author: Matteo Mori, Committer: GitHub; Can not find "Matteo Mori 169821341+MatteoMori8@users.noreply.github.com", in ["Matteo Mori matteo.mori@rvu.co.uk", "Matteo Mori matteo.mori@rvu.co.uk"].
Commit sha: 1ed98d3, Author: Matteo Mori, Committer: GitHub; Expected "Matteo Mori 169821341+MatteoMori8@users.noreply.github.com", but got "Matteo Mori matteo.mori@rvu.co.uk".
Commit sha: fd7e46c, Author: Matteo Mori, Committer: GitHub; Expected "Matteo Mori 169821341+MatteoMori8@users.noreply.github.com", but got "Matteo Mori matteo.mori@rvu.co.uk".
Commit sha: b4e356a, Author: Matteo Mori, Committer: GitHub; Can not find "Matteo Mori morimatteo14@gmail.com", in ["MatteoMori morimatteo14@gmail.com", "MatteoMori morimatteo14@gmail.com", "MatteoMori morimatteo14@gmail.com"].
Commit sha: cd46de3, Author: sara, Committer: GitHub; Expected "sara qasmisara@gmail.com", but got "Sara Qasmi saraqasmi@Saras-MacBook-Pro.local".