Skip to content

Implement mutable_copy for SparseVector #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blegat merged 1 commit into from
Sep 21, 2026
Merged

Implement mutable_copy for SparseVector #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/implementations/SparseArrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@

const _SparseMat = SparseArrays.SparseMatrixCSC

function mutable_copy(v::SparseArrays.SparseVector)
result = copy(v)
vals = SparseArrays.nonzeros(result)
map!(copy_if_mutable, vals, vals)
return result
end

function undef_array(
::Type{_SparseMat{Tv,Ti}},
rows::Base.OneTo,
Expand Down
26 changes: 26 additions & 0 deletions test/test_sparse_arrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,32 @@ function runtests()
return
end

function test_mutable_copy_sparse_vector()
for T in (Int, BigInt)
v = SparseArrays.SparseVector(1_000_000, Int32[2, 7, 13], T[1, 0, 3])
w = MA.mutable_copy(v)
@test typeof(w) === typeof(v)
@test length(w) == length(v)
@test SparseArrays.nonzeroinds(w) == Int32[2, 7, 13]
@test SparseArrays.nonzeros(w) == T[1, 0, 3]
@test SparseArrays.nonzeroinds(w) !== SparseArrays.nonzeroinds(v)
@test SparseArrays.nonzeros(w) !== SparseArrays.nonzeros(v)
if T === BigInt
MA.operate!(+, SparseArrays.nonzeros(w)[1], 1)
@test w[2] == 2
@test v[2] == 1
end
w[7] = 4
@test v[7] == 0
end
v = SparseArrays.SparseVector(10, Int32[], BigInt[])
w = MA.mutable_copy(v)
@test typeof(w) === typeof(v)
@test length(w) == 10
@test SparseArrays.nnz(w) == 0
return
end

function test_spmatmul()
Random.seed!(1234)
for m in [1, 2, 3, 5, 11]
Expand Down
Loading