Skip to content

Compound and collection attributes - #2104

Draft
bkoelman wants to merge 63 commits into
masterfrom
compound-attributes-and-collections
Draft

bkoelman wants to merge 63 commits into
masterfrom
compound-attributes-and-collections

Conversation

@bkoelman

Copy link
Copy Markdown
Member

Closes #{ISSUE_NUMBER}

QUALITY CHECKLIST

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.17339% with 185 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.24%. Comparing base (cdeb5f9) to head (be10f73).

Files with missing lines Patch % Lines
...lization/Request/Adapters/ResourceObjectAdapter.cs 48.42% 38 Missing and 11 partials ⚠️
...c/JsonApiDotNetCore/Configuration/ResourceGraph.cs 75.00% 15 Missing and 6 partials ⚠️
.../Expressions/SparseFieldSetExpressionExtensions.cs 55.55% 14 Missing and 2 partials ⚠️
...onApiDotNetCore/Queries/SparseFieldSetEvaluator.cs 77.61% 12 Missing and 3 partials ⚠️
.../JsonApiDotNetCore/Queries/Parsing/FilterParser.cs 93.33% 6 Missing and 6 partials ⚠️
...otNetCore/Queries/Parsing/QueryExpressionParser.cs 76.31% 6 Missing and 3 partials ⚠️
src/JsonApiDotNetCore/Queries/FieldSelection.cs 27.27% 7 Missing and 1 partial ⚠️
...ApiDotNetCore/Errors/InvalidModelStateException.cs 36.36% 5 Missing and 2 partials ⚠️
...e/Queries/QueryableBuilding/SelectClauseBuilder.cs 84.21% 3 Missing and 3 partials ⚠️
...tNetCore.Annotations/Configuration/CompoundType.cs 84.84% 4 Missing and 1 partial ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2104      +/-   ##
==========================================
- Coverage   92.14%   91.24%   -0.91%     
==========================================
  Files         366      375       +9     
  Lines       12125    12906     +781     
  Branches     2038     2286     +248     
==========================================
+ Hits        11173    11776     +603     
- Misses        584      727     +143     
- Partials      368      403      +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bkoelman
bkoelman force-pushed the compound-attributes-and-collections branch 4 times, most recently from 8afb96e to d6e6816 Compare October 20, 2026 01:33
@bkoelman
bkoelman force-pushed the compound-attributes-and-collections branch 8 times, most recently from 52f8d5c to f25a98a Compare October 29, 2026 22:26
bkoelman and others added 17 commits October 30, 2026 00:37
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…LeftType

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…inPattern

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…n has()

Co-authored-by: Cursor <cursoragent@cursor.com>
…or collections

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…on translation

Co-authored-by: Cursor <cursoragent@cursor.com>
…akers

Co-authored-by: Cursor <cursoragent@cursor.com>
…count, and sorts

Co-authored-by: Cursor <cursoragent@cursor.com>
bkoelman and others added 5 commits October 30, 2026 00:38
… attributes, clean up dead code

Co-authored-by: Cursor <cursoragent@cursor.com>
…01 array pointers

Co-authored-by: Cursor <cursoragent@cursor.com>
…ialization

Co-authored-by: Cursor <cursoragent@cursor.com>
@bkoelman
bkoelman force-pushed the compound-attributes-and-collections branch from f25a98a to be10f73 Compare October 29, 2026 23:38
bkoelman and others added 24 commits October 30, 2026 00:38
…g write deserialization

Co-authored-by: Cursor <cursoragent@cursor.com>
…etection

Co-authored-by: Cursor <cursoragent@cursor.com>
…record constructor rules

Co-authored-by: Cursor <cursoragent@cursor.com>
… updating fakers and tests

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ices, improve error messages, allow comparing 2 to-one relationships for equality
…ributes

- Rename SparseFieldSetCache to SparseFieldSetEvaluator
- Refactor ExpressionInScope into derived types for relationship chain (filter/sort) and resource type (fields)
- Replace SparseFieldTableExpression AST node with SparseFieldSetElementExpression (this is a tree now)
- Don't invoke redundant resource definition callbacks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant