Skip to content

Ignore non-finite parsed Max-Age values #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
offyotto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore non-finite parsed Max-Age values #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,10 @@ export function parseSetCookie(str: string, options?: ParseOptions): SetCookie {
setCookie.path = val;
break;
case "max-age":
if (val && maxAgeRegExp.test(val)) setCookie.maxAge = Number(val);
if (val && maxAgeRegExp.test(val)) {
const maxAge = Number(val);
if (Number.isFinite(maxAge)) setCookie.maxAge = maxAge;
}
break;
case "expires":
if (!val) break;
Expand Down
16 changes: 16 additions & 0 deletions src/parse-set-cookie.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,22 @@ describe("cookie.parseSetCookie", () => {
});
});

it.each(["9".repeat(310), "-" + "9".repeat(310)])(
"should ignore overflowing max-age %s",
(value) => {
expect(parseSetCookie(`key=value; Max-Age=${value}`)).toEqual({
name: "key",
value: "value",
});
},
);

it("should retain the previous max-age when a duplicate overflows", () => {
expect(
parseSetCookie(`key=value; Max-Age=60; Max-Age=${"9".repeat(310)}`),
).toEqual({ name: "key", value: "value", maxAge: 60 });
});

it("should parse negative max-age", () => {
expect(parseSetCookie("key=value; Max-Age=-1")).toEqual({
name: "key",
Expand Down
Loading