Repository navigation
fix(types): support SimplesNacionalDto events and ignore extra fields on BaseModel - #26
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra="forbid"paraextra="ignore"noBaseModelde resposta para garantir tolerância e resiliência a extensões aditivas da API da CNPJá;SimplesNacionalDto,SimplesEventDtoe enumSimplesEventRegimepara tipar eventos futuros do Simples/IBS/CBS (events);OfficeCompanyDto.simpleseSimplesDto.simplespara utilizarSimplesNacionalDto;events: []), eventos populados e descarte gracioso de campos extras não mapeados.Root cause
A API da CNPJá atualizou o endpoint
/office/:taxIdpara incluir o novo campoeventsdentro decompany.simples. Comextra="forbid", qualquer adição da API externa causavaValidationErrornos clientes consumidores (ex.:monitor-certidoes).Test Plan
task qa(lock check, ruff check, ruff format check, mypy strict, 144 testes com 96% de cobertura, pre-commit hooks)