Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/reject-overlapping-button-names #51 +/- ##
=======================================================================
Coverage 100.00% 100.00%
- Complexity 1094 1097 +3
=======================================================================
Files 120 120
Lines 2958 2967 +9
=======================================================================
+ Hits 2958 2967 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
* Reject submit names that unlock protected form fields * Roll back button registrations with failed outer renders (#51) * Cover inert buttons that share protected field names
When a custom renderer successfully rendered a named button and then failed, catching the exception and closing the same form could still accept that discarded button's name. Stage button registrations alongside pending inputs and restore them on render failure. Only the outermost successful render commits them to form protection.
This PR builds on #50's separate tracking of automatic button unlocks. Merge #50 first, then retarget this PR to
mainif GitHub does not do so automatically.Regression tests exercise a real custom renderer that renders a button before throwing, retrying the same field, preserved existing and successful buttons, rejected discarded-name injections, hidden-value tampering, and a caught nested failure that retains the outer pending button.
Validation:
composer validate --strict, formatting,composer check(834 tests, 3,342 assertions, analysis, lint, Rector, format check), and Xdebug Clover coverage: 100% (2,539/2,539 lines); greater-than-90% gate passed.All four review fixes were also merged in a temporary integration checkout without conflicts: the complete checks passed with 844 tests, 3,377 assertions, and 100% line coverage (2,549/2,549 lines).