Skip to content

Exclude non-submitting buttons from automatic unlocks - #49

Merged
josbeir merged 2 commits into
mainfrom
fix/ignore-nonsubmitting-buttons
Nov 20, 2026
Merged

josbeir merged 2 commits into
mainfrom
fix/ignore-nonsubmitting-buttons

Conversation

@josbeir

@josbeir josbeir commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

A disabled named button, type="button", or reset button previously unlocked its name despite being unable to submit it. An injected value under that name could then pass form protection. Register optional names only for enabled buttons with native submit behavior, including HTML's invalid-type fallback to submit.

Regression tests validate real CakePHP tokens with omitted buttons, injected values, and tampered hidden fields. The eligibility guard merges cleanly with the protected-name and transaction fixes.

Validation: composer validate --strict, formatting, composer check (825 tests, 3,318 assertions, analysis, lint, Rector, format check), and Xdebug Clover coverage: 100% (2,520/2,520 lines); greater-than-90% gate passed.

@codecov-commenter

codecov-commenter commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e2fa6e9) to head (c630bf1).

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #49   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1087      1089    +2     
===========================================
  Files            119       119           
  Lines           2942      2945    +3     
===========================================
+ Hits            2942      2945    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@josbeir

josbeir commented Nov 20, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T07:36:46.597925Z c630bf1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: c630bf14ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@josbeir
josbeir merged commit 5334ada into main Nov 20, 2026
4 checks passed
@josbeir
josbeir deleted the fix/ignore-nonsubmitting-buttons branch November 20, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants