Repository navigation
Exclude non-submitting buttons from automatic unlocks - #49
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1087 1089 +2
===========================================
Files 119 119
Lines 2942 2945 +3
===========================================
+ Hits 2942 2945 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A disabled named button,
type="button", or reset button previously unlocked its name despite being unable to submit it. An injected value under that name could then pass form protection. Register optional names only for enabled buttons with native submit behavior, including HTML's invalid-type fallback to submit.Regression tests validate real CakePHP tokens with omitted buttons, injected values, and tampered hidden fields. The eligibility guard merges cleanly with the protected-name and transaction fixes.
Validation:
composer validate --strict, formatting,composer check(825 tests, 3,318 assertions, analysis, lint, Rector, format check), and Xdebug Clover coverage: 100% (2,520/2,520 lines); greater-than-90% gate passed.